Update spec-compliance-matrix Zipkin section for Go#1600
Merged
carlosalberto merged 5 commits intoopen-telemetry:mainfrom Apr 12, 2021
Merged
Update spec-compliance-matrix Zipkin section for Go#1600carlosalberto merged 5 commits intoopen-telemetry:mainfrom
carlosalberto merged 5 commits intoopen-telemetry:mainfrom
Conversation
carlosalberto
approved these changes
Apr 6, 2021
Contributor
Author
|
open-telemetry/opentelemetry-go#1688 has merged, will update PR accordingly. |
Contributor
|
@MrAlias is it ready to be merged? |
jmacd
approved these changes
Apr 12, 2021
Contributor
Author
Yes, all set 👍 |
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-go#1604
For the "Integer microseconds in timestamps" entry, the Go Zipkin model uses
time.Timeandtime.Durationto represent time. Meaning, our mapping (from the same type) is just to pass these types. The specification does not appear applicable here.