-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Included Propagators section from trace API spec #1556
Conversation
This is a duplicate of the Propagators Distribution of the context specification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Not quite a duplicate, as the Propagators Distribution is a general note, while this one is about the API being the place where |
@carlosalberto I'm not sure I follow. From this section of the specification:
My understanding reading that is that the API or an extension package is the place
This excerpt from the Propagators Distribution section contains normative requirements and options and doesn't seem to be a note. |
@MrAlias You are definitely correct - the original intention of that paragraph in api.md (before the amendment in the Propagators Distribution doc), is that we really suggest SIGs to have the TraceContext (and Baggage) propagators right in the base API packages, even if distributing them as extension packages is allowed. |
@carlosalberto I'm still not 100% sure what your suggestion for a change here is? You would definitely be the one to know what the original intention was there and I don't mean to step on toes. I'm just going off what the final result ended up being and what was released. Based on how both section of the specification are written today they appear to me to be duplicates and removing the less comprehensive of the two seems like a good way to remove redundancy and avoid future confusion and internal divergences. |
@MrAlias We just need a small note here regarding that we suggest (not even a SHOULD) that SIGs include this TracePropagator in the API package/artifact itself. Will do that myself to not stale this PR any longer. Thanks! |
…ry#1556) * Remove Included Propagators section from trace API spec This is a duplicate of the Propagators Distribution of the context specification.
…ry#1556) * Remove Included Propagators section from trace API spec This is a duplicate of the Propagators Distribution of the context specification.
This is a duplicate of the Propagators Distribution of the context specification.
Fixes #1544