Make clear the propagated/non-recording span concept needs no type. #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
area:api
bogdandrutu
approved these changes
Oct 22, 2020
|
I just don't get why any of this is needed. I think I'd be fine with not using a separate context key if none of this was added to the API spec and the spec of the extractor simply said a Span should be created from propagated trace context with Edit: From #1124 it appears why I don't get why this is needed is I was missing the need for making this |
|
Also, from a performance perspective, a non-recording span can be implemented more efficiently and lightweight than a full span. |
|
And there is also no other API to create a non-recording span (except if you muck around with samplers maybe). |
carlosalberto
approved these changes
Oct 22, 2020
jmacd
approved these changes
Oct 23, 2020
anuraaga
approved these changes
Oct 23, 2020
arminru
approved these changes
Oct 23, 2020
Co-authored-by: Armin Ruech <[email protected]>
|
@open-telemetry/specs-approvers Please review. The more eyes/approvals, the better ;) |
Oberon00
changed the title
yurishkuro
approved these changes
Oct 26, 2020
SergeyKanzhelev
approved these changes
Oct 26, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…pen-telemetry#1131) * Make clear the propagated /non-recording span concept needs no type. * Update specification/trace/api.md Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Armin Ruech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1087, closes #1124, closes #1125
Changes
Makes clear that the non-recording span / propagated Span has no semantic meaning and should not be a new public type.