Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compliance matrix for removal of SpanContext or Span as parent (#510) #1079

Merged
merged 3 commits into from
Oct 13, 2020
Merged

Update compliance matrix for removal of SpanContext or Span as parent (#510) #1079

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5888d49
Update compliance matrix for #510.
Oberon00 Oct 9, 2020
00bafd2
Java implemented this already.
Oberon00 Oct 9, 2020
c0c6005
Add: SpanProcessor.OnStart receives parent Context
Oberon00 Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions spec-compliance-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ status of the feature is not known.
|Create root span | + | + | + | + | + | + | + | + | + | + |
|Create with default parent (active span) | + | + | + | + | + | + | + | + | + | + |
|Create with parent from Context | + | + | + | + | + | + | + | + | + | + |
|Create with explicit parent Span | + | + | + | + | + | + | + | - | + | + |
|Create with explicit parent SpanContext | - | + | + | + | + | + | | - | + | + |
|No explicit parent Span/SpanContext allowed | | | | | | | | | | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the first "negative" compliance? Where we actually verify that something is NOT done?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think so. It seems we did not update this matrix for the Statuscode removals/updates either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's similar to this entry in the attributes section below:

null values documented as invalid/undefined

Copy link
Member Author

@Oberon00 Oberon00 Oct 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could leave in the old lines but add a strike-through style? Then, after some transition period, we remove it. We could also add a new cell entry type like rm to signify removal of the feature.

I think the way I did it not now is the most straightforward though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, this is done in java, so you can pre-populated a + for it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkwatson Done: 00bafd2.

|UpdateName | + | + | + | + | + | + | + | + | - | + |
|User-defined start timestamp | + | + | + | + | + | + | + | + | + | + |
|End | + | + | + | + | + | + | + | + | + | + |
Expand Down