Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yaml for FaaS and Host resource attributes #1056

Merged

Conversation

thisthat
Copy link
Member

@thisthat thisthat commented Oct 5, 2020

Fixes #547

Changes

Editorial change.
This PR introduces the YAML definitions of FaaS and Host resource attributes.

@thisthat thisthat requested review from a team October 5, 2020 07:49
@arminru arminru added area:semantic-conventions Related to semantic conventions release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs labels Oct 5, 2020
semantic_conventions/resource/faas.yaml Show resolved Hide resolved
semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/faas.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/host.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/host.yaml Outdated Show resolved Hide resolved
semantic_conventions/resource/host.yaml Outdated Show resolved Hide resolved
| host.image.id | VM image id. For Cloud, this value is from the provider. | `ami-07b06b442921831e5` |
| host.image.version | The version string of the VM image. | `0.1` |
<!-- semconv host -->
| Attribute | Type | Description | Example | Required |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to have a look at what attributes are required for host, but it can be done in a separate PR.

@arminru arminru merged commit 7e0c102 into open-telemetry:master Oct 12, 2020
@arminru arminru deleted the yaml-resource-faas-host branch October 12, 2020 15:02
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
* Add yaml for FaaS and Host resource attributes

* Address feedback

Co-authored-by: Armin Ruech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:allowed-for-ga Editorial changes that can still be added before GA since they don't require action by SIGs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Define semantic conventions in JSON/YAML
4 participants