-
Notifications
You must be signed in to change notification settings - Fork 932
Closed
Labels
area:samplingRelated to trace samplingRelated to trace samplingarea:sdkRelated to the SDKRelated to the SDKpriority:p2Medium priority levelMedium priority levelrelease:required-for-gaMust be resolved before GA release, or nice to have before GAMust be resolved before GA release, or nice to have before GAspec:traceRelated to the specification/trace directoryRelated to the specification/trace directory
Description
Should the Default Sampler be changed from AlwaysOn to ParentOrElse(AlwaysOn)?
The spec suggests that AlwaysOn is the default - currently this is not truly enforced consistently across languages:
In Go (this might be a bug), the span's parent is always followed unless a different sampler is specified:
One thing that I think adds some confusion (at least for me) here is the interaction between the sampler and the Span context's TraceFlags. The spec suggests that TraceFlags should be passed down from parent to child here, but by always sampling by default this may not actually happen in practice.
MrAlias
Metadata
Metadata
Assignees
Labels
area:samplingRelated to trace samplingRelated to trace samplingarea:sdkRelated to the SDKRelated to the SDKpriority:p2Medium priority levelMedium priority levelrelease:required-for-gaMust be resolved before GA release, or nice to have before GAMust be resolved before GA release, or nice to have before GAspec:traceRelated to the specification/trace directoryRelated to the specification/trace directory