Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify Instrument.Enabled applies only for sync instruments #4200

Closed
bogdandrutu opened this issue Sep 3, 2024 · 0 comments · Fixed by #4211
Closed

Clarify Instrument.Enabled applies only for sync instruments #4200

bogdandrutu opened this issue Sep 3, 2024 · 0 comments · Fixed by #4211
Labels
spec:metrics Related to the specification/metrics directory triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor

Comments

@bogdandrutu
Copy link
Member

bogdandrutu commented Sep 3, 2024 •
edited
Loading

What are you trying to achieve?

There is a missed opportunity for an even more important optimization which is to not call the async (which I think lots of the SDK do today anyway) callback if the async instrument is NOT Enabled.

What did you expect to see?

The Enabled functionality should apply only for the sync instruments.

Additional context.

In the context of the #4063.
@bogdandrutu bogdandrutu added the spec:metrics Related to the specification/metrics directory label Sep 3, 2024
@bogdandrutu bogdandrutu mentioned this issue Sep 3, 2024
Closed
@trask trask added the triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor label Sep 3, 2024
@mx-psi mx-psi mentioned this issue Sep 9, 2024
Open
codeboten added a commit to codeboten/opentelemetry-specification that referenced this issue Sep 12, 2024
@codeboten
clarify that enabled applies to synchronous instruments
8cab133 
The Enabled API is only to be applied to synchronous instruments.

Fix open-telemetry#4200

Signed-off-by: Alex Boten <[email protected]>
@codeboten codeboten mentioned this issue Sep 12, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec:metrics Related to the specification/metrics directory triage:accepted:ready Ready to be implemented. Small enough or uncontroversial enough to be implemented without sponsor
Projects
🔭 Main Backlog
Status: Spec - Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify that enabled applies to synchronous instruments codeboten/opentelemetry-specification
2 participants
@trask @bogdandrutu