-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Decide if original and lowerCamelCase JSON keys should be supported #2795
Comments
It is not entirely clear what the definition of JSON-friendliness is. They keys used by OTLP are valid in JSON. Perhaps one decision that we need to make is whether both the original proto field name and the camelCase version of the field name should be acceptable. It is acceptable by Prototobuf JSON definition. Do we see any need to deviate from this? |
cc @mwear @dyladan @bogdandrutu @jmacd @Aneurysm9 in case you have any thoughts about this. |
I think the default behavior of the protobuf client is to change keys to lowerCamelCase and is likely what the JS exporter is currently doing. I don't see any reason not to accept both though since it is default proto behavior. |
I agree with @dyladan that we should just keep the default Protobuf behavior for exporters and also keep the ability for receivers to accept both. @open-telemetry/specs-approvers any opinions on this? |
I don't see any reason to restrict the exporters to this behavior. I would just say receivers should expect both and let exporters do what makes sense for their users expectations. |
Yes, that's essentially what will happen if we say receivers must accept both. |
…OTLP/JSON Resolves open-telemetry#2795 This is already the current understanding. This is just a clarification and describes the behavior explicitly.
…OTLP/JSON Resolves open-telemetry#2795 This is already the current understanding. This is just a clarification and describes the behavior explicitly.
…OTLP/JSON Resolves open-telemetry#2795 This is already the current understanding. This is just a clarification and describes the behavior explicitly.
Resolves open-telemetry#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
Resolves open-telemetry#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
Resolves open-telemetry#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
Resolves open-telemetry#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
…2829) Resolves open-telemetry/opentelemetry-specification#2795 This is a breaking change for OTLP/JSON and is allowed because OTLP/JSON is not yet Stable.
The decision that we need to make is whether both the original proto field name and the camelCase version of the field name should be acceptable. It is acceptable by Prototobuf JSON definition. Do we see any need to deviate from this?
The text was updated successfully, but these errors were encountered: