Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that Logger Name should be recorded as Instrumentation Scope Name #2358

Closed
tigrannajaryan opened this issue Feb 17, 2022 · 0 comments · Fixed by #3583
Closed

Clarify that Logger Name should be recorded as Instrumentation Scope Name #2358

tigrannajaryan opened this issue Feb 17, 2022 · 0 comments · Fixed by #3583
Assignees
@tigrannajaryan
Labels
help wanted Extra attention is needed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:logs Related to the specification/logs directory

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Feb 17, 2022 •
edited
Loading

The topics has been discussed at length.

This PR made possible to record instrumentation scope for traces and metrics. The intent is also to have instrumentation scope part of log data model and where available record logger name as the instrumentation scope name.

We need to make clarifications in the data model. Also we need to clarify how the logger name is dealt with by logging library SDK.
@tigrannajaryan tigrannajaryan added the spec:logs Related to the specification/logs directory label Feb 17, 2022
@tigrannajaryan tigrannajaryan self-assigned this Feb 17, 2022
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Feb 17, 2022
@tigrannajaryan
Add InstrumentationScope/Logger Name to log data model
3d1877d 
Contributes to open-telemetry#1215
Contributes to open-telemetry#2358

The topics has been discussed at length.

This [PR](open-telemetry#2276) made
possible to record instrumentation scope for traces and metrics. The intent is also to
have instrumentation scope part of log data model and where available record logger name
as the instrumentation scope name.
@tigrannajaryan tigrannajaryan mentioned this issue Feb 17, 2022
Merged
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Feb 17, 2022
@tigrannajaryan
Add InstrumentationScope/Logger Name to log data model
6129bd3 
Contributes to open-telemetry#1215
Contributes to open-telemetry#2358

The topics has been discussed at length.

This [PR](open-telemetry#2276) made
possible to record instrumentation scope for traces and metrics. The intent is also to
have instrumentation scope part of log data model and where available record logger name
as the instrumentation scope name.
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Feb 22, 2022
@tigrannajaryan
Add InstrumentationScope/Logger Name to log data model
005edd3 
Contributes to open-telemetry#1215
Contributes to open-telemetry#2358

The topics has been discussed at length.

This [PR](open-telemetry#2276) made
possible to record instrumentation scope for traces and metrics. The intent is also to
have instrumentation scope part of log data model and where available record logger name
as the instrumentation scope name.
tigrannajaryan added a commit to tigrannajaryan/opentelemetry-specification that referenced this issue Feb 22, 2022
@tigrannajaryan
Add InstrumentationScope/Logger Name to log data model
140ee3f 
Contributes to open-telemetry#1215
Contributes to open-telemetry#2358

The topics has been discussed at length.

This [PR](open-telemetry#2276) made
possible to record instrumentation scope for traces and metrics. The intent is also to
have instrumentation scope part of log data model and where available record logger name
as the instrumentation scope name.
tigrannajaryan added a commit that referenced this issue Feb 24, 2022
@tigrannajaryan
Add InstrumentationScope/Logger Name to log data model (#2359)
82deda1 
Contributes to #1215
Contributes to #2358

The topics has been discussed at length.

This [PR](#2276) made
possible to record instrumentation scope for traces and metrics. The intent is also to
have instrumentation scope part of log data model and where available record logger name
as the instrumentation scope name.
@tigrannajaryan tigrannajaryan added help wanted Extra attention is needed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR labels Jun 21, 2022
ChengJinbao added a commit to ChengJinbao/opentelemetry-specification that referenced this issue Nov 16, 2022
@ChengJinbao
Add InstrumentationScope/Logger Name to log data model (#2359)
8e825b2 
Contributes to open-telemetry/opentelemetry-specification#1215
Contributes to open-telemetry/opentelemetry-specification#2358

The topics has been discussed at length.

This [PR](open-telemetry/opentelemetry-specification#2276) made
possible to record instrumentation scope for traces and metrics. The intent is also to
have instrumentation scope part of log data model and where available record logger name
as the instrumentation scope name.
@tigrannajaryan tigrannajaryan mentioned this issue Jul 7, 2023
Merged
joaopgrassi pushed a commit to dynatrace-oss-contrib/semantic-conventions that referenced this issue Mar 21, 2024
@tigrannajaryan
Add InstrumentationScope/Logger Name to log data model (#2359)
a4a60b9 
Contributes to open-telemetry/opentelemetry-specification#1215
Contributes to open-telemetry/opentelemetry-specification#2358

The topics has been discussed at length.

This [PR](open-telemetry/opentelemetry-specification#2276) made
possible to record instrumentation scope for traces and metrics. The intent is also to
have instrumentation scope part of log data model and where available record logger name
as the instrumentation scope name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
help wanted Extra attention is needed [label deprecated] triaged-accepted [label deprecated] Issue triaged and accepted by OTel community, can proceed with creating a PR spec:logs Related to the specification/logs directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarify how log appender use Scope name and attributes tigrannajaryan/opentelemetry-specification
2 participants
@tigrannajaryan @SergeyKanzhelev