Skip to content

Commit

Permalink
remove attribute name/type from instrument creation (#1594)
Browse files Browse the repository at this point in the history
  • Loading branch information
reyang authored Apr 5, 2021
1 parent 796deb4 commit f86a465
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions specification/metrics/new_api.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,6 @@ will have the following information:
instruments, whether it is synchronous or asynchronous
* An optional `unit of measure`
* An optional `description`
* An optional list of [`Attribute`](../common/common.md#attributes) names and
types

Instruments are associated with the Meter during creation, and are identified by
the name:
Expand Down Expand Up @@ -243,8 +241,6 @@ The API MUST accept the following parameters:
rule](#instrument-unit).
* An optional `description`, following the [instrument description
rule](#instrument-description).
* An optional list of [`Attribute`](../common/common.md#attributes) names and
types.

Here are some examples that individual language client might consider:

Expand Down Expand Up @@ -319,6 +315,14 @@ for the interaction between the API and SDK.
* A value
* [`Attributes`](../common/common.md#attributes)

## Compatibility

All the metrics components SHOULD allow new APIs to be added to existing
components without introducing breaking changes.

All the metrics APIs SHOULD allow optional parameter(s) to be added to existing
APIs without introducing breaking changes.

## Concurrency

For languages which support concurrent execution the Metrics APIs provide
Expand Down

0 comments on commit f86a465

Please sign in to comment.