Add "/" to valid characters for instrument names (#3684)

open-telemetry · Sep 11, 2023 · e35305f · e35305f
1 parent 2bda856
commit e35305f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -29,6 +29,8 @@ release.
   ([#3662](https://github.com/open-telemetry/opentelemetry-specification/pull/3662))
 - Clarify the minimal implementation of a `View`'s `attribute_keys` is an allow-list.
   ([#3680](https://github.com/open-telemetry/opentelemetry-specification/pull/3680))
+- Add "/" to valid characters for instrument names
+  ([#3684](https://github.com/open-telemetry/opentelemetry-specification/pull/3684))
 
 ### Logs
 

diff --git a/spec-compliance-matrix.md b/spec-compliance-matrix.md
@@ -118,7 +118,7 @@ formats is required. Implementing more than one format is optional.
 | A valid instrument MUST be created and warning SHOULD be emitted when multiple instruments are registered under the same `Meter` using the same `name`.                |          |    | +    | +   | +      |      |        |     |      |     |      |       |
 | Duplicate instrument registration name conflicts are resolved by using the first-seen for the stream name.                                                             |          |    | +    |     |        |      |        |     |      |     |      |       |
 | It is possible to register two instruments with same `name` under different `Meter`s.                                                                                  |          | +  | +    | +   | +      |      |        |     |  +   | +   | +    |       |
-| Instrument names conform to the specified syntax.                                                                                                                      |          | -  | +    |     | +      |      |        |     | +   | +   | +    |       |
+| Instrument names conform to the specified syntax.                                                                                                                      |          |    |      |     |        |      |        |     |      |     | +    |       |
 | Instrument units conform to the specified syntax.                                                                                                                      |          | -  | +    |     | +      |      |        |     | +    | +   | +    |       |
 | Instrument descriptions conform to the specified syntax.                                                                                                               |          | -  | +    |     | -      |      |        |     |      | -   | +    |       |
 | Instrument supports the advisory ExplicitBucketBoundaries parameter.                                                                                                   |          |    | +    |     |        |      |        |     |      |     |      |       |

diff --git a/specification/metrics/api.md b/specification/metrics/api.md
@@ -206,7 +206,7 @@ The instrument name syntax is defined below using the [Augmented Backus-Naur
 Form](https://tools.ietf.org/html/rfc5234):
 
 ```abnf
-instrument-name = ALPHA 0*254 ("_" / "." / "-" / ALPHA / DIGIT)
+instrument-name = ALPHA 0*254 ("_" / "." / "-" / "/" / ALPHA / DIGIT)
 
 ALPHA = %x41-5A / %x61-7A; A-Z / a-z
 DIGIT = %x30-39 ; 0-9
@@ -215,8 +215,8 @@ DIGIT = %x30-39 ; 0-9
 * They are not null or empty strings.
 * They are case-insensitive, ASCII strings.
 * The first character must be an alphabetic character.
-* Subsequent characters must belong to the alphanumeric characters, '_', '.',
-  and '-'.
+* Subsequent characters must belong to the alphanumeric characters, '_', '.', '-',
+  and '/'.
 * They can have a maximum length of 255 characters.
 
 #### Instrument unit