Skip to content

Commit

Permalink
address PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: brunobat <[email protected]>
  • Loading branch information
brunobat committed Sep 13, 2022
1 parent 61bb5d1 commit 1ad8bb1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ release.
### SDK Configuration

- Add the definition of a Boolean environment variable
([#2755])(https://github.com/open-telemetry/opentelemetry-specification/pull/2755)
([#2755](https://github.com/open-telemetry/opentelemetry-specification/pull/2755)).

- Mark `OTEL_METRIC_EXPORT_INTERVAL`, `OTEL_METRIC_EXPORT_TIMEOUT`
environment variables as Stable
Expand Down
8 changes: 4 additions & 4 deletions specification/sdk-environment-variables.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ The SDK MUST interpret an empty value of an environment variable the same way as

### Boolean value

Any value that represents a boolean MUST interpret only the case-insensitive string "true", meaning "True" or "TRUE" are also accepted as "true".
Any value that represents a Boolean MUST be set to true only by the case-insensitive string "true", meaning "True" or "TRUE" are also accepted, as true.
An SDK MUST NOT extend this definition and define additional values that are interpreted as true.
Any value not explicitly defined here or by the SDK as a true value, including unset and empty values, MUST be interpreted as false.
If any value other than a true value, `"false"`, empty, or unset is used, a warning SHOULD be logged to inform users about the fallback to false being applied.
All boolean environment variables SHOULD be named and defined such that false is the expected safe default behavior.
Any value not explicitly defined here as a true value, including unset and empty values, MUST be interpreted as false.
If any value other than a true value, case insensitive string `"false"`, empty, or unset is used, a warning SHOULD be logged to inform users about the fallback to false being applied.
All Boolean environment variables SHOULD be named and defined such that false is the expected safe default behavior.

### Numeric value

Expand Down

0 comments on commit 1ad8bb1

Please sign in to comment.