Clarify MetricReader.Collect result

open-telemetry · Apr 18, 2022 · 0098c66 · 0098c66
1 parent a50def3
commit 0098c66
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,8 @@ release.
 
 - Clarify SDK behavior when view conflicts are present
   ([#2462](https://github.com/open-telemetry/opentelemetry-specification/pull/2462)).
+- Clarify MetricReader.Collect result
+  ([#2495](https://github.com/open-telemetry/opentelemetry-specification/pull/2495)).
 
 ### Logs
 

diff --git a/specification/metrics/sdk.md b/specification/metrics/sdk.md
@@ -710,7 +710,10 @@ Instruments](./api.md#asynchronous-instrument-api) involved, their callback
 functions will be triggered.
 
 `Collect` SHOULD provide a way to let the caller know whether it succeeded,
-failed or timed out.
+failed or timed out. When the `Collect` operation fails or timed out only on
+part of the instruments, like one async instrument callback timed out but others
+succeeded, the SDK SHOULD return all successfully collected result a failed
+reasons list to the caller.
 
 `Collect` does not have any required parameters, however, [OpenTelemetry
 SDK](../overview.md#sdk) authors MAY choose to add parameters (e.g. callback,