suggestion: CARGO_BIN_NAME instead of unknown_service as default serv…

[danielschaffel]

closes #942

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: danielschaffel (9eb9a49)

[codecov]

Codecov Report

Patch coverage: 100.0% and no project coverage change.

Comparison is base (af21bea) 69.9% compared to head (90c5e7d) 69.9%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main    #991   +/-   ##
=====================================
  Coverage   69.9%   69.9%           
=====================================
  Files        116     116           
  Lines       8920    8922    +2     
=====================================
+ Hits        6237    6245    +8     
+ Misses      2683    2677    -6     

Impacted Files	Coverage Δ
opentelemetry-sdk/src/resource/env.rs	90.0% <100.0%> (+0.2%)	⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[hdost]

Looks great! can you please update the comment docs on the SdkProvidedResourceDetector struct so that it matches the functionality as its is no longer using doing the provided steps?

[djc]

Please note that there is a difference between env!("CARGO_BIN_NAME") and env::var("CARGO_BIN_NAME"). The former gets the binary name at compile-time through a variable set by Cargo, while the former gets the value of the environment variable at run-time. IMO the former is useful for this, but the latter isn't.

[danielschaffel]

From what I understand using env!("CARGO_BIN_NAME") would make it impossible to build and test the opentelemetry-sdk package. This is because it is a lib not a bin so this method will always fail and cause an error. I chose to use option_env and not add a test because I don't know how I would test something that only happens when building the package as part of a library.

[hdost]

Again I apologize for missing this on the first review 😔