Refactor span ID and trace ID using newtype pattern #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wraps usages of span ID (u64) and trace ID (u128) in single-field tuple structs in order to enforce intention when passing around values of these types. Adds the "SpanId::invalid()" and "TraceId::invalid()" methods for conveniently creating zero-valued instances of both types.
Monkeyanator
force-pushed
the
newtype-migration-spanid-traceid
branch
from
be3e3d8
to
8b58457
Compare
jtescher
requested changes
Mar 4, 2020
|
Looks good - thanks for the contributions. I don't have any more to add than what @jtescher has already said. |
Monkeyanator
force-pushed
the
newtype-migration-spanid-traceid
branch
2 times, most recently
from
4df1714
to
d8d2e92
Compare
jtescher
requested changes
Mar 6, 2020
Adds the from_u64 and to_u64 methods to SpanId and the from_u128 and to_u128 methods to TraceId. Facilitates straightforward conversion between the wrapper structs and their wrapped uint types.
Monkeyanator
force-pushed
the
newtype-migration-spanid-traceid
branch
from
d8d2e92
to
d5107d5
Compare
cijothomas
added a commit
to cijothomas/opentelemetry-rust
that referenced
this pull request
Sep 7, 2024
…telemetry#73) Co-authored-by: Cijo Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11.
This change wraps usages of span ID (u64) and trace ID (u128) in single-field tuple structs in
order to enforce intention when passing around values of these types (i.e. the newtype pattern). Discussion on the advantages and disadvantages of this pattern can be found here.
Also adds the "SpanId::invalid()" and "TraceId::invalid()" convenience methods for creating zero-valued instances of both types.