Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MetricProducer #2105

Merged

Conversation

cijothomas
Copy link
Member

Removes MetricProducer, which is an implementation of the MetricProducer from the spec, an optional thing, which allowed metrics from external sources to be sent to OpenTelemetry. This existed for a while, but had no tests or documentation that I can find.
Removing this to keep the scope for 1.0 stable minimized, and to make it slightly easier to do further refactoring.

This is the beginning of a major set of cleanups from Metric collect/reader side of things.

Part of #1719

@cijothomas cijothomas requested a review from a team September 11, 2024 23:22
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.3%. Comparing base (5873cae) to head (0cd926b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2105   +/-   ##
=====================================
  Coverage   78.2%   78.3%           
=====================================
  Files        121     121           
  Lines      20849   20819   -30     
=====================================
- Hits       16315   16310    -5     
+ Misses      4534    4509   -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit eb0d997 into open-telemetry:main Sep 12, 2024
24 of 25 checks passed
@cijothomas cijothomas deleted the cijothomas/remove-ext-producer branch September 12, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants