Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SpanID from sampling parameters #124

Merged
merged 2 commits into from
May 31, 2020
Merged

Remove SpanID from sampling parameters #124

merged 2 commits into from
May 31, 2020

Conversation

craigpastro
Copy link
Contributor

Remove SpanID from sampling parameters as per open-telemetry/opentelemetry-specification#621.

Resolves #123.

@craigpastro craigpastro requested a review from a team May 31, 2020 04:46
MikeGoldsmith
MikeGoldsmith approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

You'll need to sign the CLA and it looks like some limiting errors were caught if you could take a look at those please.

Thank you!

@craigpastro
Copy link
Contributor Author

Fixed. Thank you!

@jtescher
Copy link
Member

Looks good, thanks!

@jtescher jtescher merged commit 13e5e37 into open-telemetry:master May 31, 2020
@craigpastro craigpastro deleted the remove-spanid-from-sampling-parameters branch May 31, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SpanId from Sampler input
3 participants
@craigpastro @jtescher @MikeGoldsmith