prometheus: add without_counter_suffixes option
#1158
Conversation
jtescher
force-pushed
the
add-without-suffix-option
branch
from
d60598e to
cc8545d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
=====================================
Coverage 49.4% 49.4%
=====================================
Files 164 164
Lines 20386 20416 +30
=====================================
+ Hits 10072 10105 +33
+ Misses 10314 10311 -3
☔ View full report in Codecov by Sentry. |
| impl Collector { | ||
| fn metric_type_and_name(&self, m: &data::Metric) -> Option<(MetricType, Cow<'static, str>)> { |
There was a problem hiding this comment.
Can we move this later when add_* functions? It may save us one downcast/runtime type check. I do see this version is easier to understand and less repetitive though but wonder if the performance wise if it make sense to avoid repeating downcast when the type is Sum
There was a problem hiding this comment.
We could, but I don't think the downcasting has any noticeable perf impact. Could do a benchmark but threads like https://users.rust-lang.org/t/downcasting-overhead/69718/6 make it pretty clear.
There was a problem hiding this comment.
Doesn't seem to make a difference when I run quick bench, can re-assess if perf becomes an issue later.
Adds
This adds a method on the prometheus exporter config to not include counter suffixes as required in this spec change open-telemetry/opentelemetry-specification#3590
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes