-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add add_link to span api/sdk #1623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for bringing the Ruby project into compliance with this spec update!
I'll defer to the @open-telemetry/ruby-maintainers to your questions about API and SDK releases.
I have a few small documentation comments.
I'm also curious about this line in the spec:
Links added after Span creation may not be considered by Samplers.
Can you tell me how links added using the add_link
method are ignored by Samplers?
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
SDK samplers, which perform head sampling (not collector samplers, or any other tail sampler) run on span creation. So when |
Thank you, @dmathieu. This connects the dots! |
The specification has recently been updated to add the ability to add span links after span creation.
See:
This updates the API and SDK to add this new method.
Note: I am not fully sure how you all are handling additive changes to the API. With Ruby being very permissive with method definitions, I assume shipping everything together is fine.
If you think that could cause an issue (like the API being used with a lower version of the SDK), I'm happy to split this PR into two, so the SDK is shipped first, and the API in another release.