Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add none as a value for OTEL_PROPAGATORS #1253

Closed
ahayworth opened this issue May 11, 2022 · 0 comments · Fixed by #1294
Closed

Add none as a value for OTEL_PROPAGATORS #1253

ahayworth opened this issue May 11, 2022 · 0 comments · Fixed by #1294
Labels
spec-compliance/v1.8.0 spec-compliance Required for OpenTelemetry spec compliance

Comments

@ahayworth
Copy link
Contributor

Added in: open-telemetry/opentelemetry-specification#2052

@ahayworth ahayworth added spec-compliance Required for OpenTelemetry spec compliance spec-compliance/v1.8.0 labels May 11, 2022
ahayworth added a commit to ahayworth/opentelemetry-ruby that referenced this issue Jun 4, 2022
Fixes open-telemetry#1253. We were already doing this if you passed an invalid value,
so I guess *technically* we were already in compliance. But now it's
explicit and without a spurious warning.
fbogsany added a commit that referenced this issue Jun 21, 2022
* feat: support OTEL_PROPAGATORS=none

Fixes #1253. We were already doing this if you passed an invalid value,
so I guess *technically* we were already in compliance. But now it's
explicit and without a spurious warning.

* fixup: fix always-passing test and more rubocop appeasement

Co-authored-by: Francis Bogsanyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-compliance/v1.8.0 spec-compliance Required for OpenTelemetry spec compliance
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant