graphql 2.1.2 tests are failing #689

arielvalentin · 2023-10-12T01:25:44Z

https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/6488928643/job/17623342092

1) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTrace::#platform_trace::when platform_resolve_type is enabled#test_0003_includes attributes [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb:269]:
  Expected nil to not be nil.
  
    2) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTrace::#platform_trace::when platform_resolve_type is enabled#test_0001_traces .resolve_type [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb:243]:
  Expected nil to not be nil.
  
    3) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTrace::#platform_trace::when platform_resolve_type is enabled#test_0002_traces .resolve_type_lazy [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb:256]:
  Expected nil to not be nil.
  
    4) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTrace::#platform_trace::when platform_authorized is enabled with legacy naming#test_0001_traces .authorized [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb:181]:
  Expected nil to not be nil.
  
    5) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTrace::#platform_trace::when platform_field is enabled with legacy naming#test_0001_traces execute_field [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb:124]:
  Expected nil to not be nil.
  
    6) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTracer::#platform_trace::when a set of schemas is provided#test_0001_traces the provided schemas [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb:107]:
  Expected: 8
    Actual: 16
  
    7) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTracer::#platform_trace::when a set of schemas is provided#test_0002_does not trace all schemas [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb:113]:
  Expected [#<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.lex", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\xE6\x81.\xA1\x16\x15r\x98", total_recorded_attributes=0, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215167401, end_timestamp=1697068117215214101, attributes={}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="\b\x0F:\x15x\xA6\x01S", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>, #<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.parse", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\xE6\x81.\xA1\x16\x15r\x98", total_recorded_attributes=0, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215248402, end_timestamp=1697068117215311702, attributes={}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="]\xE4\xCElQ\x87\xF1M", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>, #<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.validate", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\xE6\x81.\xA1\x16\x15r\x98", total_recorded_attributes=0, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215[344](https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/6488928643/job/17623342092#step:3:357)002, end_timestamp=1697068117215496503, attributes={}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="\x14\xCC\xD3\xAA\x05~\xB3\f", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>, #<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.analyze_multiplex", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\xE6\x81.\xA1\x16\x15r\x98", total_recorded_attributes=0, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215527603, end_timestamp=1697068117215535903, attributes={}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="B\xC3\xC3\x86K\xB3Sx", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>, #<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.analyze_query", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\x98\xCEg\xDCt}3Z", total_recorded_attributes=0, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215117301, end_timestamp=1697068117215541803, attributes={}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="\xE6\x81.\xA1\x16\x15r\x98", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>, #<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.execute_query", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\x98\xCEg\xDCt}3Z", total_recorded_attributes=3, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215582003, end_timestamp=1697068117215678204, attributes={"graphql.operation.name"=>"SimpleQuery", "graphql.operation.type"=>"query", "graphql.document"=>"query SimpleQuery{ __typename }"}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="S\x80\xE5\xF0\a`9\b", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>, #<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.execute_query_lazy", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\x98\xCEg\xDCt}3Z", total_recorded_attributes=0, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215704504, end_timestamp=1697068117215712204, attributes={}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="\x1EO\t$\xE1*\xC4_", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>, #<struct OpenTelemetry::SDK::Trace::SpanData name="graphql.execute_multiplex", kind=:internal, status=#<OpenTelemetry::Trace::Status:0x00007fb5fe68b3a0 @code=1, @description="">, parent_span_id="\x00\x00\x00\x00\x00\x00\x00\x00", total_recorded_attributes=0, total_recorded_events=0, total_recorded_links=0, start_timestamp=1697068117215075401, end_timestamp=1697068117215724004, attributes={}, links=nil, events=nil, resource=#<OpenTelemetry::SDK::Resources::Resource:0x00007fb5fe2b4150 @attributes={"service.name"=>"unknown_service", "process.pid"=>1978, "process.command"=>"/opt/hostedtoolcache/Ruby/3.2.1/x64/lib/ruby/gems/3.2.0/gems/rake-13.0.6/lib/rake/rake_test_loader.rb", "process.runtime.name"=>"ruby", "process.runtime.version"=>"3.2.1", "process.runtime.description"=>"ruby 3.2.1 (2023-02-08 revision 31819e82c8) [x86_64-linux]", "telemetry.sdk.name"=>"opentelemetry", "telemetry.sdk.language"=>"ruby", "telemetry.sdk.version"=>"1.3.0"}>, instrumentation_scope=#<struct OpenTelemetry::SDK::InstrumentationScope name="OpenTelemetry::Instrumentation::GraphQL", version="0.26.7">, span_id="\x98\xCEg\xDCt}3Z", trace_id="\xCD!\xE0L3\x05=\x12\x16\x04H\xCE\xD45;\xAE", trace_flags=#<OpenTelemetry::Trace::TraceFlags:0x00007fb5fe456a30 @flags=1>, tracestate=#<OpenTelemetry::Trace::Tracestate:0x00007fb5fe453f10 @hash={}>>] to be empty?.
  
    8) Failure:
  OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTracer::#platform_trace#test_0001_traces platform keys [/home/runner/work/opentelemetry-ruby-contrib/opentelemetry-ruby-contrib/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb:64]:
  --- expected
  +++ actual
  @@ -1 +1 @@
  -["graphql.lex", "graphql.parse", "graphql.validate", "graphql.analyze_query", "graphql.analyze_multiplex", "graphql.execute_query", "graphql.execute_query_lazy", "graphql.execute_multiplex"]
  +["graphql.lex", "graphql.parse", "graphql.validate", "graphql.validate", "graphql.analyze_multiplex", "graphql.analyze_query", "graphql.execute_query", "graphql.execute_query_lazy", "graphql.execute_multiplex"]

arielvalentin · 2023-10-12T01:25:49Z

@swalkinshaw Do you have time to help us look into this?

swalkinshaw · 2023-10-12T15:58:15Z

@rmosolgo heads up looks like rmosolgo/graphql-ruby#4642 caused these regressions

rmosolgo · 2023-10-12T19:27:41Z

Maybe it's not handling inheritance from GraphQL::Schema properly, looking at how this is set
up:

https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/20e1cd04f8167276453b27469912e90984a291ac/instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/instrumentation.rb#L90C24-L90C30

👀

rmosolgo · 2023-10-12T19:56:02Z

Ok, got it, I think it's this: https://github.com/rmosolgo/graphql-ruby/pull/4642/files#diff-ca02a7189be9dc9f1c0d328028ba139f8be8da82eca96bbfccd3c098b5ad03f7R905

There's a failing test in rmosolgo/graphql-ruby#4663

rmosolgo · 2023-10-12T20:45:53Z

I just shipped GraphQL-Ruby 2.1.3 with a patch that fixes these failures for me locally -- let me know if you get trouble after running CI with that new version!

swalkinshaw · 2023-10-12T20:46:44Z

Thanks for the quick fix @rmosolgo

arielvalentin · 2023-10-13T03:24:15Z

@rmosolgo @swalkinshaw mind taking a look at these errors?

https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/6490672800/job/17664369533

rmosolgo · 2023-10-13T12:33:23Z

Oh! Sorry I didn't notice those before. I was only running the one test file, but it looks like those failures started because of changes in GraphQL-Ruby's internal trace storage structure. I can make those pass by modifying the reset code:

--- a/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb
+++ b/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_trace_test.rb
@@ -97,8 +97,7 @@ describe OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTrace do

         after do
           # Reset various instance variables to clear state between tests
-          SomeOtherGraphQLAppSchema.instance_variable_set(:@own_tracers, [])
-          SomeOtherGraphQLAppSchema.instance_variable_set(:@own_plugins, SomeOtherGraphQLAppSchema.plugins[0..1])
+          [GraphQL::Schema, SomeOtherGraphQLAppSchema, SomeGraphQLAppSchema].each(&:_reset_tracer_for_testing)
         end

         it 'traces the provided schemas' do
diff --git a/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb b/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb
index 496580be..35e5e4b0 100644
--- a/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb
+++ b/instrumentation/graphql/test/instrumentation/graphql/tracers/graphql_tracer_test.rb
@@ -97,13 +97,11 @@ describe OpenTelemetry::Instrumentation::GraphQL::Tracers::GraphQLTracer do

         after do
           # Reset various instance variables to clear state between tests
-          SomeOtherGraphQLAppSchema.instance_variable_set(:@own_tracers, [])
-          SomeOtherGraphQLAppSchema.instance_variable_set(:@own_plugins, SomeOtherGraphQLAppSchema.plugins[0..1])
+          [GraphQL::Schema, SomeOtherGraphQLAppSchema, SomeGraphQLAppSchema].each(&:_reset_tracer_for_testing)
         end

         it 'traces the provided schemas' do
           SomeOtherGraphQLAppSchema.execute('query SimpleQuery{ __typename }')
-
           _(spans.size).must_equal(8)
         end

diff --git a/instrumentation/graphql/test/test_helper.rb b/instrumentation/graphql/test/test_helper.rb
index 330b3d83..75f349b2 100644
--- a/instrumentation/graphql/test/test_helper.rb
+++ b/instrumentation/graphql/test/test_helper.rb
@@ -25,7 +25,7 @@ module SchemaTestPatches
   # Reseting @graphql_definition is needed for tests running against version `1.9.x`
   # Other variables are used by ~> 2.0.19
   def _reset_tracer_for_testing
-    %w[own_tracers trace_modes trace_class tracers graphql_definition].each do |ivar|
+    %w[own_tracers trace_modes trace_class tracers graphql_definition own_trace_modes].each do |ivar|
       remove_instance_variable("@#{ivar}") if instance_variable_defined?("@#{ivar}")
     end
   end

How about that?

arielvalentin · 2023-10-13T12:39:50Z

Thank your for your help!

I appreciate that you are taking the time to help us with this instrumentation.

Please open a PR!

rmosolgo · 2023-10-13T13:09:41Z

sure! 💁‍♂️ #691

@simi

* chore: use stable toys version * chore: use stable version of toys release code * release: Release 2 gems (open-telemetry#675) * fix: Fix "uses cases" typo in `CONTRIBUTING.md` (open-telemetry#679) * chore(deps-dev): update webmock requirement from ~> 3.18.1 to ~> 3.19.1 in /resources/azure (open-telemetry#653) * chore(deps-dev): update webmock requirement from ~> 3.18.1 to ~> 3.19.1 in /resources/google_cloud_platform (open-telemetry#652) * fix: Remove dependence on activesupport (open-telemetry#687) Instrumentations must not use transitive dependencies used by the library. In this case, relying on the gruf library to load specific ActiveSupport extensions leaves the instrumentation vulnerable to bugs. For this reason I have changed the code to use Enumerable methods instead of ActiveSupport extensions. See open-telemetry#686 * fix!: Drop DelayedJob ActiveRecord in Tests (open-telemetry#685) * fix: Add Rails 7.1 compatability (open-telemetry#684) * chore: Add tests for Rails 7.1 * fix: Rails 7.1 incompatabilities * feat!: obfuscation for mysql2, dalli and postgresql as default option for db_statement (open-telemetry#682) * feat!: fuscation for mysql2, dalli and pg * feat!: update readme * feat!: set db.statement option to obfuscate by default for mysql2, pg and dalli Co-authored-by: Ariel Valentin <[email protected]> * ci: Update test reset code for GraphQL-Ruby 2.1.3 (open-telemetry#691) Fixes open-telemetry#689 * fix: Omit `nil` `net.peer.name` attributes (open-telemetry#693) * ci: upgrade to latest stable version of toys (open-telemetry#694) Fixes errors with incompatible versions defined in the configs: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/6534421626/job/17741560442#step:5:10 * release: Release 12 gems (open-telemetry#695) * release: Release 12 gems * opentelemetry-instrumentation-gruf 0.1.1 (was 0.1.0) * opentelemetry-instrumentation-active_support 0.4.3 (was 0.4.2) * opentelemetry-instrumentation-action_view 0.6.1 (was 0.6.0) * opentelemetry-instrumentation-action_pack 0.7.1 (was 0.7.0) * opentelemetry-instrumentation-active_job 0.6.1 (was 0.6.0) * opentelemetry-instrumentation-active_record 0.6.3 (was 0.6.2) * opentelemetry-instrumentation-dalli 0.25.0 (was 0.24.2) * opentelemetry-instrumentation-delayed_job 0.22.0 (was 0.21.0) * opentelemetry-instrumentation-faraday 0.23.3 (was 0.23.2) * opentelemetry-instrumentation-mysql2 0.25.0 (was 0.24.3) * opentelemetry-instrumentation-pg 0.26.0 (was 0.25.3) * opentelemetry-instrumentation-rails 0.28.1 (was 0.28.0) * ci: Trigger builds * fix: Apply suggestions from code review Co-authored-by: Josef Šimánek <[email protected]> * fix: bump gem versions * fix: bump gems --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Josef Šimánek <[email protected]> * chore: Update CODEOWNERS (open-telemetry#692) * chore: Update CODEOWNERS Add @simi and @kaylareopelle and approvers to the list * release: Release opentelemetry-instrumentation-all 0.51.0 (was 0.50.1) (open-telemetry#699) * release: Release opentelemetry-instrumentation-all 0.51.0 (was 0.50.1) * docs: Update all gem Changelog --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat(trilogy): instrument connect and ping (open-telemetry#704) These can be just as slow as a query if not slower. Co-authored-by: Jean Boussier <[email protected]> * fix: Remove dependency on ActiveSupport core extensions from Grape instrumentation (open-telemetry#706) * release: Release opentelemetry-instrumentation-trilogy 0.57.0 (was 0.56.3) (open-telemetry#708) * release: Release opentelemetry-instrumentation-trilogy 0.57.0 (was 0.56.3) * Empty commit * Release instrumentation-all as well. --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Francis Bogsanyi <[email protected]> * chore(deps): update rubocop requirement from ~> 1.56.2 to ~> 1.57.1 (open-telemetry#702) Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.2...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /instrumentation/base (open-telemetry#701) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /resource_detectors (open-telemetry#700) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /propagator/ottrace (open-telemetry#698) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /propagator/xray (open-telemetry#697) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove opentelemetry-resource_detectors all-in-one gem (open-telemetry#659) * fix: remove call to ActiveSupport::Notifications.notifier#synchronize deprecated in Rails 7.2 (open-telemetry#707) * wrap call to depcrecated private API behind version conditional * convert Rails version string to Gem::Version * fix module access? * check for synchronize method instead of Rails version * add comment --------- Co-authored-by: Ariel Valentin <[email protected]> * chore: Fix linter issue * release: Release 2 gems (open-telemetry#710) * release: Release 2 gems * opentelemetry-instrumentation-grape 0.1.5 (was 0.1.4) * opentelemetry-instrumentation-active_support 0.4.4 (was 0.4.3) * ci: Force --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sam Bostock <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Xuan <[email protected]> Co-authored-by: Robert Mosolgo <[email protected]> Co-authored-by: Yohei Kitamura <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Josef Šimánek <[email protected]> Co-authored-by: Jean byroot Boussier <[email protected]> Co-authored-by: Jean Boussier <[email protected]> Co-authored-by: Muriel <[email protected]> Co-authored-by: Francis Bogsanyi <[email protected]> Co-authored-by: Sander Jans <[email protected]> Co-authored-by: Katherine Oelsner <[email protected]>

* fix: Remove dependence on activesupport (#687) Instrumentations must not use transitive dependencies used by the library. In this case, relying on the gruf library to load specific ActiveSupport extensions leaves the instrumentation vulnerable to bugs. For this reason I have changed the code to use Enumerable methods instead of ActiveSupport extensions. See https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/686 * fix!: Drop DelayedJob ActiveRecord in Tests (#685) * fix: Add Rails 7.1 compatability (#684) * chore: Add tests for Rails 7.1 * fix: Rails 7.1 incompatabilities * feat!: obfuscation for mysql2, dalli and postgresql as default option for db_statement (#682) * feat!: fuscation for mysql2, dalli and pg * feat!: update readme * feat!: set db.statement option to obfuscate by default for mysql2, pg and dalli Co-authored-by: Ariel Valentin <[email protected]> * ci: Update test reset code for GraphQL-Ruby 2.1.3 (#691) Fixes https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/689 * fix: Omit `nil` `net.peer.name` attributes (#693) * ci: upgrade to latest stable version of toys (#694) Fixes errors with incompatible versions defined in the configs: https://github.com/open-telemetry/opentelemetry-ruby-contrib/actions/runs/6534421626/job/17741560442#step:5:10 * release: Release 12 gems (#695) * release: Release 12 gems * opentelemetry-instrumentation-gruf 0.1.1 (was 0.1.0) * opentelemetry-instrumentation-active_support 0.4.3 (was 0.4.2) * opentelemetry-instrumentation-action_view 0.6.1 (was 0.6.0) * opentelemetry-instrumentation-action_pack 0.7.1 (was 0.7.0) * opentelemetry-instrumentation-active_job 0.6.1 (was 0.6.0) * opentelemetry-instrumentation-active_record 0.6.3 (was 0.6.2) * opentelemetry-instrumentation-dalli 0.25.0 (was 0.24.2) * opentelemetry-instrumentation-delayed_job 0.22.0 (was 0.21.0) * opentelemetry-instrumentation-faraday 0.23.3 (was 0.23.2) * opentelemetry-instrumentation-mysql2 0.25.0 (was 0.24.3) * opentelemetry-instrumentation-pg 0.26.0 (was 0.25.3) * opentelemetry-instrumentation-rails 0.28.1 (was 0.28.0) * ci: Trigger builds * fix: Apply suggestions from code review Co-authored-by: Josef Šimánek <[email protected]> * fix: bump gem versions * fix: bump gems --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Josef Šimánek <[email protected]> * chore: Update CODEOWNERS (#692) * chore: Update CODEOWNERS Add @simi and @kaylareopelle and approvers to the list * release: Release opentelemetry-instrumentation-all 0.51.0 (was 0.50.1) (#699) * release: Release opentelemetry-instrumentation-all 0.51.0 (was 0.50.1) * docs: Update all gem Changelog --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat(trilogy): instrument connect and ping (#704) These can be just as slow as a query if not slower. Co-authored-by: Jean Boussier <[email protected]> * fix: Remove dependency on ActiveSupport core extensions from Grape instrumentation (#706) * release: Release opentelemetry-instrumentation-trilogy 0.57.0 (was 0.56.3) (#708) * release: Release opentelemetry-instrumentation-trilogy 0.57.0 (was 0.56.3) * Empty commit * Release instrumentation-all as well. --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Francis Bogsanyi <[email protected]> * chore(deps): update rubocop requirement from ~> 1.56.2 to ~> 1.57.1 (#702) Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.56.2...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /instrumentation/base (#701) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /resource_detectors (#700) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /propagator/ottrace (#698) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 in /propagator/xray (#697) chore(deps-dev): update rubocop requirement from ~> 1.56.1 to ~> 1.57.1 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.56.1...v1.57.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove opentelemetry-resource_detectors all-in-one gem (#659) * fix: remove call to ActiveSupport::Notifications.notifier#synchronize deprecated in Rails 7.2 (#707) * wrap call to depcrecated private API behind version conditional * convert Rails version string to Gem::Version * fix module access? * check for synchronize method instead of Rails version * add comment --------- Co-authored-by: Ariel Valentin <[email protected]> * chore: Fix linter issue * release: Release 2 gems (#710) * release: Release 2 gems * opentelemetry-instrumentation-grape 0.1.5 (was 0.1.4) * opentelemetry-instrumentation-active_support 0.4.4 (was 0.4.3) * ci: Force --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * added httpx opentelemetry adapter (#681) * added httpx opentelemetry adapter * Update instrumentation/httpx/CHANGELOG.md Co-authored-by: Ariel Valentin <[email protected]> * Update instrumentation/httpx/README.md Co-authored-by: Ariel Valentin <[email protected]> * Update instrumentation/httpx/README.md Co-authored-by: Ariel Valentin <[email protected]> --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Josef Šimánek <[email protected]> * chore: Fix HTTPx attribute and changelog (#711) * chore: Change release restrictions The toys gem checks that all actions are passing before allowing a release request to be opened, however only the CI builds are actually required. This change limits the release request requirements to look specifically for CI builds * chore: Fix httpx version * chore: bump toys * release: Release opentelemetry-instrumentation-httpx 0.1.0 (initial release) (#713) * release: Release opentelemetry-instrumentation-httpx 0.1.0 (initial release) * Update instrumentation/httpx/CHANGELOG.md * feat!: Drop Rails 6.0 EOL (#680) * feat!: Drop Rails 6.0 EOL 6.0 is no longer receiving maintenance, security, or feature updates as of 01 Jun 2023 Users who want to continue instrumentating Rails applications should pin to earlier versions of the instrumentation. * squash: Fix test * squash: gem version object instead of string * Update README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Inline gemspec dev constraints with Appraisals. (#716) * Removal Sinatra 1.x Appraisal (#715) fix: Removal Sinatra 1.x Appraisal Rack 1.x is not directly supported anymore. Sinatra 1.x in turn "is not". Removal appraisal and add a compatibility note to both Sinatra and Rack for proper instrumentation version usage. Co-authored-by: Ariel Valentin <[email protected]> * feat!(active_job): Use ActiveSupport instead of patches (#677) * feat!(active_job): Use ActiveSupport instead of patches * refactor: Register discard job * refactor: independent registration * refactor: Use template methods for children * refactor: some more small fixes * refactor: a little clean up * refactor: a little more clarity * refactor: try to make sense of a few things * refactor: fix test directory structure * refactor: extract to files * add some docs * refactor: clean up and renames * refactor: split tests out per handler * refactor... maybe a little overengineering * fix: add examples of in-line instrumentation * Update README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update default.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update perform.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * squash: Use Singleton Tracer * fix: Use top level namespaces When used in conjunction with the `OpenTelemetry::Instrumenation::ActiveSupport`, the classloader would mistakenly use the wrong namespace and raises a `NameError`. This change updates references to ensure we use top level namespaces to load the appropriate classes. * squash: Update instrumentation/active_job/README.md Co-authored-by: Robb Kidd <[email protected]> * squash: Update docs Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * squash: Reduce Local Variable Allocation Co-authored-by: Robb Kidd <[email protected]> * squash: Safe navigation no longer required * squash: fix bad commit * squash: Remove possible PII from status message * squash: PR Feedback * squash: Use up to date semconv and remove unused attrs * squash: remove unused file * squash: fix test * squash: fix messaging id * squash: More semconv fixes * squash: fix ids * squash: feedback from Ruby SIG --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]> Co-authored-by: Robb Kidd <[email protected]> * release: Release 6 gems (#724) * release: Release 6 gems * opentelemetry-instrumentation-active_support 0.5.0 (was 0.4.4) * opentelemetry-instrumentation-action_view 0.7.0 (was 0.6.1) * opentelemetry-instrumentation-action_pack 0.8.0 (was 0.7.1) * opentelemetry-instrumentation-active_job 0.7.0 (was 0.6.1) * opentelemetry-instrumentation-active_record 0.7.0 (was 0.6.3) * opentelemetry-instrumentation-rails 0.29.0 (was 0.28.1) * docs: Update instrumentation/active_job/CHANGELOG.md * chore: bump all dependencies * chore: bump version file * chore: bump rails dependencies --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * fix: Get Rdkafka version from VERSION contant (#726) * fix: Update `Net::HTTP` instrumentation to no-op on untraced contexts (#722) * chore: Add rspec-mocks development dependency * fix: Net::HTTP instrumentation no-op on untraced context Update Net::HTTP instrumentation to no-op on HTTP requests within untraced contexts. Prevents the logging of "called finish on an ended Span" messages. Example scenario: The Resque instrumentation can be configured to call `OpenTelemetry::SDK::TraceProvider#force_flush` at the end of each job. That causes the batch span processor to immediately send everything it has to the OTLP exporter. The exporter then marks the HTTP request used to send the data to the APM server as "untraced", by adding an `untraced` key to the context and setting it to `true`. Before this commit, the `Net::HTTP` instrumentation did not check for the `untraced` flag. So it would try set attributes and call `finish` on a span that was not recording, creating one "called finish on an ended Span" log entry for each batch of exported spans. On a large application, that results in millions of those log entries per minute. --------- Co-authored-by: Ariel Valentin <[email protected]> * release: Release 2 gems (#728) * release: Release 2 gems * opentelemetry-instrumentation-rdkafka 0.4.1 (was 0.4.0) * opentelemetry-instrumentation-net_http 0.22.3 (was 0.22.2) * ci: Force --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * chore(dev-deps): Add rubocop-performance (#727) chore(dev-deps): Add and enable rubocop-performance * release: Release opentelemetry-instrumentation-rdkafka 0.4.2 (#731) * release: Release 23 gems (#732) * release: Release 23 gems * opentelemetry-propagator-ottrace 0.21.2 (was 0.21.1) * opentelemetry-propagator-xray 0.22.1 (was 0.22.0) * opentelemetry-instrumentation-base 0.22.3 (was 0.22.2) * opentelemetry-instrumentation-active_job 0.7.1 (was 0.7.0) * opentelemetry-instrumentation-active_support 0.5.1 (was 0.5.0) * opentelemetry-instrumentation-concurrent_ruby 0.21.2 (was 0.21.1) * opentelemetry-instrumentation-delayed_job 0.22.1 (was 0.22.0) * opentelemetry-instrumentation-ethon 0.21.3 (was 0.21.2) * opentelemetry-instrumentation-excon 0.21.3 (was 0.21.2) * opentelemetry-instrumentation-faraday 0.23.4 (was 0.23.3) * opentelemetry-instrumentation-grape 0.1.6 (was 0.1.5) * opentelemetry-instrumentation-graphql 0.26.8 (was 0.26.7) * opentelemetry-instrumentation-http 0.23.2 (was 0.23.1) * opentelemetry-instrumentation-http_client 0.22.3 (was 0.22.2) * opentelemetry-instrumentation-httpx 0.1.1 (was 0.1.0) * opentelemetry-instrumentation-mongo 0.22.2 (was 0.22.1) * opentelemetry-instrumentation-net_http 0.22.4 (was 0.22.3) * opentelemetry-instrumentation-pg 0.26.1 (was 0.26.0) * opentelemetry-instrumentation-que 0.7.1 (was 0.7.0) * opentelemetry-instrumentation-rack 0.23.5 (was 0.23.4) * opentelemetry-instrumentation-restclient 0.22.3 (was 0.22.2) * opentelemetry-instrumentation-rspec 0.3.2 (was 0.3.1) * opentelemetry-instrumentation-rails 0.29.1 (was 0.29.0) * chore: Apply suggestions from code review --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * perf(graphql): cache attribute hashes (#723) * GraphQL: cache attribute hashes * Use caches for GraphQLTracer attributes * Use the same attribute hashes for resolve_type and authorized * revert changes to legacy trace --------- Co-authored-by: Ariel Valentin <[email protected]> * release: Release 2 gems (#741) * feat!: Add a connect span to excon (#712) * Add a connect span to excon and add more span attributes to the tracer middleware * Skip matching on the error message as it varies by platform * Rescue the IOError that can occur on accept * Switch to must_be_empty assertion instead of size * Move allowing and disallowing connect to setup and after respectively. * use dig when getting hostname and port of proxy * Call untraced when we hit an untraced host. * Switch to using recording? to test whether we should finish a span. * Switch to handle_error instead of debug logging. * Record the exception on error * Perform the next step in the middleware stack in the context of the current span. * Add assertions on http spans to connect tests. * Fix rubocop lints * Remove interpolation from status message on span now that we capture exceptions as an event. * Switch to attach and detach instead of with_span * Include untraced context into untraced? check for the middleware and patch. * Add test for untraced. * Add a module that centralizes the untraced hosts concern. * Expand doc comment. * Move module to the excon gem. * Add doc comment for untraced? in the concern * Update instrumentation/excon/lib/opentelemetry/instrumentation/excon/middlewares/tracer_middleware.rb Co-authored-by: Ariel Valentin <[email protected]> --------- Co-authored-by: Ariel Valentin <[email protected]> * release: Release 2 gems (#744) * chore: Fix Rails 7.2 secrets deprecation warning (#747) * feat!(action_pack): Use ActiveSupport instead of patches (#703) * feat!(action_pack): Use ActiveSupport instead of patches * feat!(action_pack): remove comments * feat: drop 6.0 on action_pack to verify the test case * feat: add rails 6.0 back * feat!(action_pack): remove rails 6.0 support + update readme on error handling * Update instrumentation/action_pack/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers/action_controller.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_pack/lib/opentelemetry/instrumentation/action_pack/handlers.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * update Approvers list in README (#755) Kayla and Josef are already approvers! This brings the docs up-to-date with reality. * chore(deps-dev): update rubocop to ~> 1.58.0 in multiple gems (#756) * chore(deps-dev): update rubocop to ~> 1.58.0 in multiple gems * appease Rubocop: Lint/RedundantSafeNavigation Redundant safe navigation with default literal detected. prefix = endpoint.routes.first.options[:prefix]&.to_s || '' ^^^^^^^^^^^^ OK. We can stop at safely navigating the string coersion without supplying a default because paths.reject{} below filters nils. * appease Rubocop: Style/RedundantReturn Redundant return detected. return "HTTP #{request_method} #{request_path} miniswan" ^^^^^^ Sure. * appease Rubocop: Style/RedundantParentheses Don't use parentheses around a logical expression. (!gem_version.nil? && gem_version >= MINIMUM_VERSION) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ OK. * chore(deps): bump actions/stale from 8 to 9 (#757) * chore: let stalebot close issues after 30 days of being stale. (#759) * feat!: change db.mysql.instance.address to db.instance.id (#758) * refactor(trilogy): change db.mysql.instance.address to db.instance.id fixes #745 * feat!(trilogy): change db.mysql.instance.address to db.instance.id fixes #745 --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * chore(deps-dev): update rubocop to ~> 1.59.0 in all gems (#760) * chore(deps): update rubocop requirement from ~> 1.58.0 to ~> 1.59.0 Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.58.0...v1.59.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * chore(deps-dev): also update rubocop to ~> 1.59.0 in all the gemspecs --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Robb Kidd <[email protected]> * fix: Backport Rack proxy event to middleware (#764) * chore: update codeowners * chore: Add Tests for GraphQL C Parser (#773) Graphql 2.2 introduces an optional C implementation of the Parser as well as optimizations to the pure Ruby parser that result in changes to what is captured during instrumentation. Users of the pure Ruby implementation will no longer see graphql.lex spans emitted as a part of their traces and will instead need to switch to using the C Parser in order to explicitly see time spent in the lexer. This PR introduces updates to the test suite to add coverage for the C Parser and changes to the Ruby implementation. There are no underlying changes in the instrumentation itself. * chore: Experiment with GCP Release Please (#729) * chore: Experiment with GCP Release Please An experiment to replace toys. https://github.com/google-github-actions/release-please-action/tree/main * squash: fixes from PR feedback * squash: Give otel bot the credit * squash: pin to v4.0.2 * squash: add steps to execute the release * squash: fix output * squash: release one at a time * chore: fix actions definition * chore: Fixes for release-please * chore: use objects not arrays * chore: Remove invalid config * chore: Remove nested objects in config * chore: Prerelease config * chore: Fix release version paths * chore: try again * chore: Block matrix from running if no release were created * chore: try https://github.com/orgs/community/discussions/27096 * chore: remove superflous action config * feat(rack)! Use Rack Events By Default (#709) * feat(rack)! Use Rack Events By Default I have been running the `Rack::Events` based instrumentation in our production workloads since 2023-10-23. There is no noticeable difference in performance, however applications using `Rack::BodyProxy` to stream responses will notice a slight increase in latency since it will include timings writing response output to the socket. * squash: fix invalid HTTP responses in tests * squash: Remove redundant test * squash: Update rack error description * Update instrumentation.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * ci: Use Org OTel Bot Token (#789) The Org Level OTel Bot Token likely a PAT, which will allow PRs opened by GH actions to trigger subsequent actions workflows. This will fix the problem where CI jobs do not run when the bot opens a PR for release requests. * Revert "ci: Use Org OTel Bot Token (#789)" (#790) This reverts commit 586b0fb137d430e2b826f3814723dd61c8d82ff1. * Trilogy: only set `db.instance.id` attribute if there is a value (#792) * fix: Trilogy only set db.instance.id attribute if there is a value (#792) * ci: OTel Bot Token Redux * feat!: Use Rack Events By Default * ci: Revert token again * chore: release main (#793) * chore: release main * feat: Update Trilogy and Rack --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> * ci: force latest bundler version * ci: invalid option * ci: Fix toys config * ci: Try again * Revert "chore: release main (#793)" This reverts commit 9d8788b8b27f4492eba9d6f60cafcee95ecad148. * ci: Give Credit to OTel Bot * release: Release 2 gems (#796) * release: Release 2 gems * opentelemetry-instrumentation-trilogy 0.58.0 (was 0.57.0) * opentelemetry-instrumentation-rack 0.24.0 (was 0.23.5) * feat!: All Upgrade Trilogy:0.58 Rack:0.24 --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * release: Release opentelemetry-instrumentation-all 0.55.0 (was 0.54.0) (#799) * release: Release opentelemetry-instrumentation-all 0.55.0 (was 0.54.0) * ci: Update instrumentation/all/CHANGELOG.md --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * release: Release 3 gems (#808) * release: Release 3 gems * opentelemetry-instrumentation-all 056.0 (was 0.55.0) * opentelemetry-instrumentation-action_pack 0.9.0 (was 0.8.0) * opentelemetry-instrumentation-rails 0.30.0 (was 0.29.1) * Apply suggestions from code review * squash: Bump dependencies --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * chore: Bump rubocop-performance 1.20.0 (#780) ```console $> bin/update-dependencies rubocop-performance 1.20.0 ``` * ci: Add Tests For Ruby 3.3 (#797) * ci: Add Tests For Ruby 3.3 Ruby 3.3 is out so this PR adds actions to test against it. One this to note is that bigcommerce/gruf does not yet support Ruby 3.3. Once https://github.com/bigcommerce/gruf/pull/197 is merged I will update the test suite to include gruf again. * squash: fix test * squash: fix test * chore(deps): bump ruby/setup-ruby from 1.162.0 to 1.165.1 (#809) * Add xuan-cao-swi to approvers (#810) * ci: Update Release Please Configs * ci: Use appropriate config * ci: fix job names * ci: Use correct job names * ci: update manifest versions * ci: bump rack manifest * ci: Fix Job Refs * ci: remove hyphens * ci: fix reference * chore(deps): update rubocop-performance requirement from ~> 1.19.1 to ~> 1.20.2 (#807) Updates the requirements on [rubocop-performance](https://github.com/rubocop/rubocop-performance) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-performance/releases) - [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.19.1...v1.20.2) --- updated-dependencies: - dependency-name: rubocop-performance dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs: Add note about running update-dependencies in ubuntu-linux (#819) * chore: Update rubocop version to 1.60.0 (#818) * chore: Update rubocop version to 1.60.0 * chore: Update rubocop in main Gemfile * chore: Address Rubocop offenses Incorporate Style/ArgumentsForwarding - Use shorthand syntax ... for arguments forwarding. * chore(deps): bump ruby/setup-ruby from 1.165.1 to 1.167.0 (#820) * fix: "Getting Started" link at README (#822) * docs: ✏️ Sidekiq instrumentation options (#824) * chore: add appraisal for Sinatra 4. (#827) * chore: add appraisal for Sinatra 4. * chore: allow for latest minor version of rack-test. * chore: add rackup to sinatra example Gemfile (#828) Co-authored-by: Sam <[email protected]> * chore: Update rubocop to 1.60.1 (#823) * chore(deps): bump ruby/setup-ruby from 1.167.0 to 1.169.0 (#829) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.167.0 to 1.169.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Commits](https://github.com/ruby/setup-ruby/compare/v1.167.0...v1.169.0) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: Remove disable directives leftover from older version of Rubocop (#835) * docs: relocate Resque config option comments to render in Yard docs (#834) docs: move config option docs up to the Instrumentation class As formatted markdown comments on the class, the information is made visible in the Yard-generated docs without making the options appear to be class or instance variables. * chore(deps): bump ruby/setup-ruby from 1.169.0 to 1.170.0 (#836) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.169.0 to 1.170.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Commits](https://github.com/ruby/setup-ruby/compare/v1.169.0...v1.170.0) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump ruby/setup-ruby from 1.170.0 to 1.171.0 (#838) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.170.0 to 1.171.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Commits](https://github.com/ruby/setup-ruby/compare/v1.170.0...v1.171.0) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor!: Move shared sql behavior to helper gems (#529) * chore(deps): bump actions/checkout from 3 to 4 (#844) * chore: Update releases path * chore: force initial release version (#851) * chore: force initial release version * squash: temporarily disable version until helpers are released * feat: Propagate context to Vitess (#850) * feat: Propagate context to Vitess * Require base64 * Refactor to extract Vitess propagator * Use in-repo vitess propagator * The actual tests * Remove unnecessary require * Robust against frozen string carrier * Update README * Fix test * Test with mutable strings * Update instrumentation/trilogy/test/opentelemetry/instrumentation/trilogy/instrumentation_test.rb Co-authored-by: Robert <[email protected]> * Appease the cop --------- Co-authored-by: Robert <[email protected]> * chore: Update toys and toys release script pins to 0.15.5 (#854) * release: Release 3 gems (#856) * release: Release 3 gems * opentelemetry-helpers-mysql 0.1.0 (initial release) * opentelemetry-helpers-sql-obfuscation 0.1.0 (initial release) * opentelemetry-propagator-vitess 0.1.0 (initial release) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * release: Release 8 gems (#857) * release: Release 8 gems * opentelemetry-instrumentation-trilogy 0.59.0 (was 0.58.0) * opentelemetry-instrumentation-resque 0.5.1 (was 0.5.0) * opentelemetry-instrumentation-bunny 0.21.2 (was 0.21.1) * opentelemetry-instrumentation-mysql2 0.26.0 (was 0.25.0) * opentelemetry-instrumentation-pg 0.27.0 (was 0.26.1) * opentelemetry-instrumentation-que 0.8.0 (was 0.7.1) * opentelemetry-instrumentation-sidekiq 0.25.1 (was 0.25.0) * opentelemetry-instrumentation-all 0.57.0 (was 0.56.0) * ci: Force * fix!: Upgrade dependencies --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * docs: Fix doc for sidekiq options (#825) * docs: ✏️ fix yard for sidekiq instrumentation options * docs: Refactor Sidekiq instrumentation and add configuration options * Update instrumentation/sidekiq/lib/opentelemetry/instrumentation/sidekiq.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/sidekiq/lib/opentelemetry/instrumentation/sidekiq/instrumentation.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> --------- Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * ci: Add Conventional Commit Linter (#800) * ci: Add Conventional Commit Linter * squash: remove unused action * squash: Delete commitlint.config.js * squash: PR feedback * squash: Update contributing guide * squash: PR Feedback * fix: add missing requires for sql-helpers to mysql, pg, and trilogy instrumentation (#859) * release: Release 4 gems (#860) * release: Release 4 gems * opentelemetry-instrumentation-trilogy 0.59.1 (was 0.59.0) * opentelemetry-instrumentation-mysql2 0.26.1 (was 0.26.0) * opentelemetry-instrumentation-pg 0.27.1 (was 0.27.0) * opentelemetry-instrumentation-sidekiq 0.25.2 (was 0.25.1) * ci: force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * fix: return nil for non-existant key in AwsSdk::MessageAttributeGetter (#853) Co-authored-by: Ariel Valentin <[email protected]> * release: Release opentelemetry-instrumentation-aws_sdk 0.5.1 (was 0.5.0) (#861) * release: Release opentelemetry-instrumentation-aws_sdk 0.5.1 (was 0.5.0) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat: instrument mysql2 prepare statement (#862) * feat: instrument prepare for mysql2 lib * revision * release: Release 2 gems (#868) * release: Release 2 gems * opentelemetry-instrumentation-mysql2 0.27.0 (was 0.26.1) * opentelemetry-instrumentation-all 0.58.0 (was 0.57.0) * Update instrumentation/all/CHANGELOG.md * squash: Bump mysql2 gem --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat!: Cache GraphQL attributes (#867) * release: Release 2 gems (#871) * release: Release 2 gems * opentelemetry-instrumentation-graphql 0.28.0 (was 0.27.0) * opentelemetry-instrumentation-all 0.59.0 (was 0.58.0) * squash: Apply suggestions from code review * squash: Bump GraphQL --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat: Add support gruf 2.19 (#872) * fix: dup string if frozen in trilogy query (#863) * fix: propagate context from trilogy instrumentation for frozen strings * feat: faraday add support for internal spans (#873) * release: Release opentelemetry-instrumentation-trilogy 0.59.2 (was 0.59.1) (#875) Co-authored-by: OpenTelemetry Bot <[email protected]> * release: Release 3 gems (#881) * release: Release 3 gems * opentelemetry-instrumentation-gruf 0.2.0 (was 0.1.1) * opentelemetry-instrumentation-faraday 0.24.0 (was 0.23.4) * opentelemetry-instrumentation-all 0.60.0 (was 0.59.0) * docs: Update instrumentation/all/CHANGELOG.md * chore: bump dependencies --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * chore: Update rubocop and rubocop-performance in helper gems (#878) * chore: drop dependency on ruby2_keywords (#885) Now that Ruby below 2.7 is not supported anymore (#389, https://github.com/open-telemetry/opentelemetry-ruby-contrib/commit/38b083aa41b93bcc8f900cd65bc922c97fe26e5d) this is not needed anymore * chore: Update stalebot (#889) * chore(deps): bump ruby/setup-ruby from 1.171.0 to 1.172.0 (#883) * chore(deps): bump ruby/setup-ruby from 1.172.0 to 1.173.0 (#911) * fix: Propagate response attributes on Faraday::Error (#912) feat: Propagate response attributes on Faraday::Error The current `Faraday` middleware won't report `http.status_code` in cases where an error is raised via another middleware (such as `:raise_error` or `:json`). This adds a special case for subclasses of `Faraday::Error` which have response information available, so that `http.status_code` the span status are still added to the span. * release: Release opentelemetry-instrumentation-faraday 0.24.1 (was 0.24.0) (#913) * release: Release opentelemetry-instrumentation-faraday 0.24.1 (was 0.24.0) * ci: force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * chore: Fix typo in event_handler_resiliency_test.rb filename (#914) * chore: Update rubocop to 1.62 (#910) * chore: Update rubocop to 1.62 * Rubocop updates * add an empty line after a magic comment * remove redundant line continuation --------- Co-authored-by: Ariel Valentin <[email protected]> * chore(deps): bump google-github-actions/release-please-action from 4.0.2 to 4.1.0 (#908) chore(deps): bump google-github-actions/release-please-action Bumps [google-github-actions/release-please-action](https://github.com/google-github-actions/release-please-action) from 4.0.2 to 4.1.0. - [Release notes](https://github.com/google-github-actions/release-please-action/releases) - [Changelog](https://github.com/google-github-actions/release-please-action/blob/main/CHANGELOG.md) - [Commits](https://github.com/google-github-actions/release-please-action/compare/v4.0.2...v4.1.0) --- updated-dependencies: - dependency-name: google-github-actions/release-please-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * docs: fix typo where Rake is mentioned instead of Rack (#922) * chore: Run release-please only on open-telemetry (#917) Currently, release-please attempts to run on forks of opentelemetry-ruby-contrib. The workflow fails with the message "GitHub Actions is not permitted to create or approve pull requests." release-please is not needed on forks. Co-authored-by: Ariel Valentin <[email protected]> * fix: instrumentation/active_record: add `:allow_retry` option to `find_by_sql` patch (#915) fix: instrumentation/active_record add :allow_retry option to find_by_sql patch Rails 7.2 (rails/rails@eabcff2) introduces the :allow_retry option for this method, so we need to add it to this patch to maintain compatibility. Co-authored-by: Kayla Reopelle (she/her) <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * chore(deps-ci): upgrade conventional commit check (#923) [email protected] includes an update[1] that recognizes scopes that contain hyphens. [1] https://github.com/dev-build-deploy/commit-me/commit/38d4cb09a1bf468012516a3bfbfad325f3435915 * chore(deps-dev): update rubocop-performance requirement from ~> 1.20.1 to ~> 1.21.0 in /helpers/sql-obfuscation (#921) chore(deps-dev): update rubocop-performance requirement from ~> 1.20.1 to ~> 1.21.0 Updates the requirements on [rubocop-performance](https://github.com/rubocop/rubocop-performance) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-performance/releases) - [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.20.1...v1.21.0) --- updated-dependencies: - dependency-name: rubocop-performance dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> * chore(deps-dev): update rubocop-performance requirement from ~> 1.20.1 to ~> 1.21.0 in /helpers/mysql (#919) chore(deps-dev): update rubocop-performance requirement from ~> 1.20.1 to ~> 1.21.0 Updates the requirements on [rubocop-performance](https://github.com/rubocop/rubocop-performance) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-performance/releases) - [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.20.1...v1.21.0) --- updated-dependencies: - dependency-name: rubocop-performance dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> * chore(deps-dev): update webmock requirement from ~> 3.19.1 to ~> 3.23.0 in /resources/azure (#888) chore(deps-dev): update webmock requirement from ~> 3.19.1 to ~> 3.23.0 Updates the requirements on [webmock](https://github.com/bblimke/webmock) to permit the latest version. - [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md) - [Commits](https://github.com/bblimke/webmock/compare/v3.19.1...v3.23.0) --- updated-dependencies: - dependency-name: webmock dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> * chore(deps): update rubocop-performance requirement from ~> 1.20.2 to ~> 1.21.0 (#920) Updates the requirements on [rubocop-performance](https://github.com/rubocop/rubocop-performance) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-performance/releases) - [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.20.2...v1.21.0) --- updated-dependencies: - dependency-name: rubocop-performance dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> * chore: Move @kaylareopelle to maintainers list (#926) * fix: fix markdown header (#925) * fix: suppress deprecation warning in Rdkafka Instrumentation (#884) * fix: suppress deprecation warning in Rdkafka Instrumentation * memoize getter * Use constant * rubocop fix --------- Co-authored-by: Ariel Valentin <[email protected]> * chore: update webmock requirement from ~> 3.19.1 to ~> 3.20.0 in /resources/google_cloud_platform (#847) chore(deps-dev): update webmock requirement from ~> 3.19.1 to ~> 3.20.0 Updates the requirements on [webmock](https://github.com/bblimke/webmock) to permit the latest version. - [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md) - [Commits](https://github.com/bblimke/webmock/compare/v3.19.1...v3.20.0) --- updated-dependencies: - dependency-name: webmock dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kayla Reopelle (she/her) <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * release: Release 4 gems (#928) * release: Release 4 gems * opentelemetry-instrumentation-racecar 0.3.1 (was 0.3.0) * opentelemetry-instrumentation-rdkafka 0.4.3 (was 0.4.2) * opentelemetry-instrumentation-active_record 0.7.1 (was 0.7.0) * opentelemetry-instrumentation-rack 0.24.1 (was 0.24.0) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * fix: analyze span names in GraphQL instrumentation (#930) * release: Release opentelemetry-instrumentation-graphql 0.28.1 (was 0.28.0) (#931) * chore: bump dev-build-deploy/commit-me from 1.4.0 to 1.4.1 (#932) * chore: bump ruby/setup-ruby from 1.173.0 to 1.174.0 (#936) * fix: resolve active_record testing issue (#944) * fix: resolve active_record issue * Update instrumentation/active_record/Gemfile Co-authored-by: Ariel Valentin <[email protected]> --------- Co-authored-by: Ariel Valentin <[email protected]> * chore: bump ruby/setup-ruby from 1.174.0 to 1.175.0 (#943) Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.174.0 to 1.175.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Commits](https://github.com/ruby/setup-ruby/compare/v1.174.0...v1.175.0) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: update webmock requirement from ~> 3.20.0 to ~> 3.23.0 in /resources/google_cloud_platform (#929) chore: update webmock requirement from ~> 3.20.0 to ~> 3.23.0 Updates the requirements on [webmock](https://github.com/bblimke/webmock) to permit the latest version. - [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md) - [Commits](https://github.com/bblimke/webmock/compare/v3.20.0...v3.23.0) --- updated-dependencies: - dependency-name: webmock dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> * fix: revert modifications to Apache license (#935) See open-telemetry/community#2056 for background Co-authored-by: Ariel Valentin <[email protected]> * chore: bump ruby/setup-ruby from 1.175.0 to 1.175.1 (#945) * ci: Remove unused jobs (#947) * chore: JRuby 9.4.6.0 - Ruby 3.1 (#952) * chore: JRuby 9.4.6.0 - Ruby 3.1 Update CI to run JRuby under Ruby 3.1 * ci: Update Ruby Action * feat: Add baggage span processor (#937) * fix: Cancel duplicate builds (#954) This change cancels any pending builds when someone pushes changes before the tests are complete * ci: Setup Weekly Releases (#949) This job will create a release request every week at least one hour before or during the Ruby SIG. This will ensure are aware of any pending releases during the SIG meeting and choose to submit a release. * chore: include new baggage span processor in release automation (#959) tell toys about the new baggage span processor Follow up to #937 to make the gem releasable with our automation. * fix: Bundler conflict warnings (#951) Fixes https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/938 * release: Release 35 gems (#960) * ci: Add nightly builds (#948) * ci: Add nightly builds This should allow us to get ahead of any gem incompatabilities * squash: remove unused action * chore: Release on Tuesdays * chore: bump ruby/setup-ruby from 1.175.1 to 1.176.0 (#963) * fix: rack event baggage handling (#965) * release: Release opentelemetry-instrumentation-rack 0.24.3 (was 0.24.2) (#967) * release: Release opentelemetry-instrumentation-rack 0.24.3 (was 0.24.2) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * fix: Untrace entire request (#968) * fix: untraced in rack event middleware * chore: bump common across the board * release: Release 13 gems (#970) * release: Release 13 gems * opentelemetry-instrumentation-rdkafka 0.4.5 (was 0.4.4) * opentelemetry-instrumentation-http_client 0.22.5 (was 0.22.4) * opentelemetry-instrumentation-koala 0.20.4 (was 0.20.3) * opentelemetry-instrumentation-dalli 0.25.2 (was 0.25.1) * opentelemetry-instrumentation-ethon 0.21.5 (was 0.21.4) * opentelemetry-instrumentation-excon 0.22.2 (was 0.22.1) * opentelemetry-instrumentation-faraday 0.24.3 (was 0.24.2) * opentelemetry-instrumentation-net_http 0.22.5 (was 0.22.4) * opentelemetry-instrumentation-rack 0.24.4 (was 0.24.3) * opentelemetry-instrumentation-redis 0.25.5 (was 0.25.4) * opentelemetry-instrumentation-restclient 0.22.5 (was 0.22.4) * opentelemetry-instrumentation-sidekiq 0.25.4 (was 0.25.3) * opentelemetry-instrumentation-sinatra 0.23.4 (was 0.23.3) --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Robert Laurin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat: add aws Lambda instrumentation (#721) * feat: add aws lambda instrumentation * feat: return original handler response and require the handler file * Update instrumentation/aws_lambda/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/example/Gemfile Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: revision on fix sample test, update readme and add rubocop-performance * feat: update readme * Update instrumentation/aws_lambda/CHANGELOG.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/version.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: add codeowner for aws_lambda * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update CODEOWNERS Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: lambda - update semantic convention and test case * feat: add lambda to workflow * feat: lambda - run test with rake test directly * feat: lambda - add rescue to avoid break user function * feat: aws lambda - make faas.trigger static to http as following spec. add cloud account id * Update instrumentation/aws_lambda/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: lambda - use symbol and str for statusCode * feat: lambda - refactor on status code * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: lambda - update span name calculation period. add non-http trigger and test case * feat: aws_lambda update * feat: aws lambda - update attributes * feat: aws lambda - revision * Update instrumentation/aws_lambda/README.md Co-authored-by: Lin Lin <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Lin Lin <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Lin Lin <[email protected]> * feat: aws lambda - revision * Update instrumentation/aws_lambda/example/sample.rb Co-authored-by: Ariel Valentin <[email protected]> * Update instrumentation/aws_lambda/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/lib/opentelemetry/instrumentation/aws_lambda/handler.rb Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/aws_lambda/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: lambda - update release file * feat: remove ci-instrumentation-canary.yml --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]> Co-authored-by: Lin Lin <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat: Support prepend SQL comment for PG instrumentation (#690) Co-authored-by: Ariel Valentin <[email protected]> Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * release: Release 2 gems (#975) * release: Release 2 gems * opentelemetry-instrumentation-pg 0.27.3 (was 0.27.2) * opentelemetry-instrumentation-aws_lambda 0.1.0 (initial release) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * feat: add instrumentation support for action mailer (#887) * feat: add notification support for action mailer * feat: action mailer typo * Update instrumentation/action_mailer/example/app/views/test_mailer/welcome_email.html.erb Co-authored-by: Ariel Valentin <[email protected]> * feat: action mailer: omit email address * feat: actionmailer updated readme * feat: actionmailer exclude mail attributes * feat: force email out of attr * feat: actionmailer use ecs email convention * feat: revision * feat: restrict on modifying original payload * feat: revision * Update instrumentation/action_mailer/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_mailer/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: revision * Update instrumentation/action_mailer/example/trace_request_demonstration.ru Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * Update instrumentation/action_mailer/README.md Co-authored-by: Kayla Reopelle (she/her) <[email protected]> --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * ci: Add ActionMailer CI (#976) * ci: Add ActionMailer CI * ci: Linter fixes * squash: drop pry-byebug * ci: fix action_mailer version Initial versions must be 0.0.0 * release: Release opentelemetry-instrumentation-action_mailer 0.1.0 (initial release) (#979) * release: Release opentelemetry-instrumentation-action_mailer 0.1.0 (initial release) * ci: force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * docs: Instrumentation Authors Guide (#946) * release: Release opentelemetry-instrumentation-grape 0.1.8 (was 0.1.7) (#985) * release: Release opentelemetry-instrumentation-grape 0.1.8 (was 0.1.7) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * chore: Update release please action to googleapis (#989) The previous location, google-github-actions, is deprecated. All future work will be completed in googleapis. * fix: add action_mailer to rails and all (#984) * fix: add action_mailer to rails and all * fix: lint --------- Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * feat: add aws lambda to instrumentation-all (#986) fix: add aws lambda to instrumentation-all Co-authored-by: Kayla Reopelle (she/her) <[email protected]> * chore: Update Rubocop to 1.64.0 (#997) * chore: Rubocop Style/SuperArguments * chore: Rubocop Style/RedundantParentheses * chore: Rubocop Style/RedundantFreeze Lint/SuppressedException * chore: Rubocop Layout/SpaceInsideHash * chore: Update Rubocop to 1.64.0 * chore: Rubocop Style/SuperArguments * chore: bump ruby/setup-ruby from 1.176.0 to 1.178.0 (#996) * chore: bump ruby/setup-ruby from 1.176.0 to 1.178.0 Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.176.0 to 1.178.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Commits](https://github.com/ruby/setup-ruby/compare/v1.176.0...v1.178.0) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * squash: bump reusable test action --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ariel Valentin <[email protected]> * test: Add vitess to the propagators matrix (#998) * release: Release 2 gems (#1000) * release: Release 2 gems * opentelemetry-instrumentation-rails 0.30.2 (was 0.30.1) * opentelemetry-instrumentation-all 0.61.0 (was 0.60.0) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * fix: Add net.peer.name to ethon (#1004) The ethon instrumentation did not include the `net.peer.name` attribute like other HTTP instrumentations and was not ported from ddtrace-rb: <https://github.com/DataDog/dd-trace-rb/blob/master/lib/datadog/tracing/contrib/ethon/easy_patch.rb#L159> This attribute is important to GitHub because we base the `peer.service` extracting the subdomain and host information from `net.peer.name`. In order to avoid parsing the URL multiple times, I inlined the common gem `cleanse_url` function and plan to open a separate PR adding a feature to support returing URI objects instead of Strings. * ci: Updates grape appraisals (#1006) Fixes https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/1005 * release: Release opentelemetry-instrumentation-ethon 0.21.6 (was 0.21.5) (#1008) * release: Release opentelemetry-instrumentation-ethon 0.21.6 (was 0.21.5) * ci: Force --------- Co-authored-by: OpenTelemetry Bot <[email protected]> Co-authored-by: Ariel Valentin <[email protected]> * test: Fix grape test suite (#1017) `builder` was removed as a dependency to `grape` but is used by active support in some versions. See ruby-grape/grape#2443 See ruby-grape/grape#2445 Fixes https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/1015 * chore: bump ruby/setup-ruby from 1.178.0 to 1.180.0 (#1009) * chore: bump ruby/setup-ruby from 1.178.0 to 1.180.0 Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.178.0 to 1.180.0. - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Commits](https://github.com/ruby/setup-ruby/compare/v1.178.0...v1.180.0) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-type: direct:production update-type: version-update:semver-minor ... …

rmosolgo mentioned this issue Oct 12, 2023

Fix OpenTelemetry legacy trace rmosolgo/graphql-ruby#4663

Merged

rmosolgo mentioned this issue Oct 13, 2023

Update test reset code for GraphQL-Ruby 2.1.3 #691

Merged

arielvalentin closed this as completed in dd90f32 Oct 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

graphql 2.1.2 tests are failing #689

graphql 2.1.2 tests are failing #689

arielvalentin commented Oct 12, 2023

arielvalentin commented Oct 12, 2023

swalkinshaw commented Oct 12, 2023

rmosolgo commented Oct 12, 2023

rmosolgo commented Oct 12, 2023

rmosolgo commented Oct 12, 2023

swalkinshaw commented Oct 12, 2023

arielvalentin commented Oct 13, 2023

rmosolgo commented Oct 13, 2023

arielvalentin commented Oct 13, 2023

rmosolgo commented Oct 13, 2023

graphql 2.1.2 tests are failing #689

graphql 2.1.2 tests are failing #689

Comments

arielvalentin commented Oct 12, 2023

arielvalentin commented Oct 12, 2023

swalkinshaw commented Oct 12, 2023

rmosolgo commented Oct 12, 2023

rmosolgo commented Oct 12, 2023

rmosolgo commented Oct 12, 2023

swalkinshaw commented Oct 12, 2023

arielvalentin commented Oct 13, 2023

rmosolgo commented Oct 13, 2023

arielvalentin commented Oct 13, 2023

rmosolgo commented Oct 13, 2023