Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing for gRPC Client Interceptor #896

Merged
merged 4 commits into from
Jul 16, 2020
Merged

Testing for gRPC Client Interceptor #896

merged 4 commits into from
Jul 16, 2020

Conversation

cnnradams
Copy link
Member

part 1/2 of #878

Also adds status code responses to the interceptor.

@cnnradams cnnradams requested a review from a team July 10, 2020 16:55
@cnnradams cnnradams mentioned this pull request Jul 10, 2020
Closed
@cnnradams cnnradams force-pushed the grpc_client_testing branch 2 times, most recently from ea2fd38 to 996e03a Compare July 10, 2020 19:33
codeboten
codeboten suggested changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the PR. Change looks good, if you wouldn't mind updating the changelog then i can approve.

@cnnradams
Copy link
Member Author

Thanks for splitting the PR. Change looks good, if you wouldn't mind updating the changelog then i can approve.

updated the changelog

toumorokoshi
toumorokoshi approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did a light review. thanks!

ext/opentelemetry-ext-grpc/CHANGELOG.md Outdated
@@ -2,6 +2,9 @@

## Unreleased

- Add status code to gRPC client, gRPC client testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"gRPC client testing" is unnescessary, as that doesn't affect the user directly.

Copy link
Member Author

@cnnradams cnnradams Jul 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cnnradams cnnradams force-pushed the grpc_client_testing branch 2 times, most recently from b5a5c9e to c3009a4 Compare July 15, 2020 16:01
@codeboten codeboten merged commit ee9d28a into open-telemetry:master Jul 16, 2020
@cnnradams cnnradams mentioned this pull request Jul 21, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@dyladan
Do not export empty span lists (open-telemetry#896)
c15f360 
* chore: remove in-memory polling timer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@toumorokoshi toumorokoshi toumorokoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cnnradams @codeboten @toumorokoshi