-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing for gRPC Client Interceptor #896
Testing for gRPC Client Interceptor #896
Conversation
ea2fd38
to
996e03a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting the PR. Change looks good, if you wouldn't mind updating the changelog then i can approve.
updated the changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a light review. thanks!
@@ -2,6 +2,9 @@ | |||
|
|||
## Unreleased | |||
|
|||
- Add status code to gRPC client, gRPC client testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"gRPC client testing" is unnescessary, as that doesn't affect the user directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
b5a5c9e
to
c3009a4
Compare
5c5d282
to
f14a04f
Compare
* chore: remove in-memory polling timer
part 1/2 of #878
Also adds status code responses to the interceptor.