[WIP] Add typing information for contexts, token #4346
Draft
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mrnicegyu11
changed the title
mrnicegyu11
changed the title
|
Dear maintainers, on the original PR #4164 I cannot see the details of the github action test failures, to me the code contribution by @hyoinandout looks good and mergeable. If there are incompatabilities with the python-contrib-instrumentations I am willing to look into it, but for this I'd need to see the github-action-results/failures ;) |
mrnicegyu11
changed the title
Kludex
reviewed
Dec 24, 2024
| @@ -64,7 +64,7 @@ def test_attach(self): | |||
| self.assertEqual("yyy", context.get_value("a")) | |||
|
|
|||
| with self.assertLogs(level=ERROR): | |||
| context.detach("some garbage") | |||
| context.detach("some garbage") # type:ignore | |||
There was a problem hiding this comment.
Why is the type: ignore needed?
Suggested change
| context.detach("some garbage") # type:ignore | |
| context.detach("some garbage") # type: ignore[?] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to get #4164 in.
Opening this 1:1 similar PR for now, with changes from upstream/main, to see how the tests look. Locally, all tests are green.
This is WIP for now.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran the
toxfull test suite locally, all green. Waiting for maintainer approval for the github actions testsDoes This PR Require a Contrib Repo Change?
Checklist: