Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use travis pypy3 #408

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Use travis pypy3 #408

merged 1 commit into from
Feb 11, 2020

Conversation

c24t
Copy link
Member

@c24t c24t commented Feb 11, 2020

Instead of pypy3.5, debugging #406.

Fixes #406.

@c24t c24t requested a review from a team February 11, 2020 02:12
@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #408 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #408     +/-   ##
=========================================
- Coverage   85.27%   85.18%   -0.1%     
=========================================
  Files          38       38             
  Lines        1956     1937     -19     
  Branches      231      230      -1     
=========================================
- Hits         1668     1650     -18     
  Misses        221      221             
+ Partials       67       66      -1
Impacted Files Coverage Δ
...ry-sdk/src/opentelemetry/sdk/resources/__init__.py 68.18% <0%> (-2.66%) ⬇️
...ry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py 67.59% <0%> (-0.59%) ⬇️
...opentelemetry/sdk/context/propagation/b3_format.py 86.79% <0%> (-0.49%) ⬇️
opentelemetry-sdk/src/opentelemetry/sdk/util.py 85.54% <0%> (-0.35%) ⬇️
...ts/src/opentelemetry/ext/http_requests/__init__.py 89.47% <0%> (-0.27%) ⬇️
...src/opentelemetry/ext/opentracing_shim/__init__.py 95.76% <0%> (-0.18%) ⬇️
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py 86.39% <0%> (-0.16%) ⬇️
...app/src/opentelemetry_example_app/flask_example.py 100% <0%> (ø) ⬆️
...emetry-sdk/src/opentelemetry/sdk/trace/__init__.py 90.67% <0%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7a809...d3781d9. Read the comment docs.

@c24t
Copy link
Member Author

c24t commented Feb 11, 2020

Looking back at #95, it's not clear why we're using pypy3.5 here instead of pypy, which the travis docs recommend.

Not as satisfying as solving the actual underlying travis issue, but we can unblock builds with this PR now and revisit if we have a reason to target pypy3.5 specifically in the future.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this

@c24t
Copy link
Member Author

c24t commented Feb 11, 2020

Entering god mode to merge and unblock builds.

@c24t c24t merged commit 7229435 into open-telemetry:master Feb 11, 2020
@c24t c24t deleted the try-pypy3 branch February 11, 2020 02:42
toumorokoshi pushed a commit to toumorokoshi/opentelemetry-python that referenced this pull request Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failures in pypy3.5 job
3 participants