Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry-semantic-conventions: bump to v1.26.0 #3964

Merged
merged 4 commits into from
Jun 20, 2024
Merged

opentelemetry-semantic-conventions: bump to v1.26.0 #3964

merged 4 commits into from
Jun 20, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Jun 11, 2024 •
edited by lzchen
Loading

Description

Rebuild semconv for schema v1.26.0

Fixes #3868

Fixes #3964

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team June 11, 2024 08:14
@xrmx xrmx force-pushed the bump-semconv-1260 branch from 3151ebf to 5481b81 Compare June 11, 2024 08:14
@xrmx
Copy link
Contributor Author

xrmx commented Jun 12, 2024 •
edited
Loading

@lmolkova Is this something safe to do or should we wait for #3927 ?

This was referenced Jun 12, 2024
Closed
Merged
@xrmx xrmx marked this pull request as draft June 13, 2024 08:09
@xrmx
opentelemetry-semantic-conventions: bump to v1.26.0
8559e5f 
We need to add the deprecated messaging.client_id to the
EXCLUDED_ATTRIBUTES in order to avoid a name clash with messaging.client.id.
@xrmx xrmx force-pushed the bump-semconv-1260 branch from 5481b81 to 8559e5f Compare June 17, 2024 13:05
@xrmx xrmx marked this pull request as ready for review June 17, 2024 13:07
@xrmx xrmx requested review from lmolkova and lzchen June 17, 2024 13:07
lmolkova
lmolkova approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lzchen lzchen merged commit 3ed6303 into open-telemetry:main Jun 20, 2024
269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl ocelotl approved these changes

@lmolkova lmolkova lmolkova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GenAI Semantic Convention
4 participants
@xrmx @lmolkova @ocelotl @lzchen