Use imporlib.metadata on python >=3.10 #3373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This api is no longer provisional in 3.10 and this reduces the number of dependencies for any instrumented code on >= 3.10 Fixes open-telemetry#3234
|
Seems like these is a an api difference so I will close until I had a change to investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This api is no longer provisional in 3.10 and this reduces the number of dependencies for any instrumented code on >= 3.10
See the official docs
This was suggested in #3234 but never implemented.
Fixes #3234
and avoids issues such as #3333 on those versions in the future.
In my opinion it's a really nice feature of opentelemetry (compared to opencensus) that the api only has
very light dependencies. Currently it has 5 dependencies. Of these one is setuptools which can be dropped (#3372)
and 2 are importlib-metadata and iss dependency zipp. Both or these are std lib backports so with these changes they
are dropped.
(The remaining dependencies are Deprecated and its dependency wrapt)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The used importlib functionality is well tested within the codebase. These tests are
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/oropentelemetry-sdk/The method interfaces of
test/utilhave changedScripts in
scripts/that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.tomlisort.cfg.flake8When a new
.github/CODEOWNERis addedMajor changes to project information, such as in:
README.mdCONTRIBUTING.mdYes. - Link to PR:
No.
Checklist: