Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and use missing metrics environment variables #2968

Merged
merged 5 commits into from
Oct 31, 2022
Merged

Add and use missing metrics environment variables #2968

merged 5 commits into from
Oct 31, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Oct 7, 2022

Fixes #2967

@ocelotl ocelotl marked this pull request as ready for review October 7, 2022 15:30
@ocelotl ocelotl requested a review from a team October 7, 2022 15:30
@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Oct 7, 2022
@ocelotl ocelotl self-assigned this Oct 10, 2022
@ocelotl ocelotl force-pushed the issue_2967 branch 2 times, most recently from 91a13d1 to 62f8a87 Compare October 14, 2022 14:31
@ocelotl ocelotl requested a review from lzchen October 14, 2022 14:33
@ocelotl ocelotl mentioned this pull request Oct 27, 2022
Open
@ocelotl ocelotl mentioned this pull request Oct 31, 2022
Open
@srikanthccv
Copy link
Member

@ocelotl please resolve the conflicts.

@ocelotl ocelotl merged commit fa19e1f into open-telemetry:main Oct 31, 2022
@ocelotl ocelotl deleted the issue_2967 branch October 31, 2022 22:40
@Yamakaky Yamakaky mentioned this pull request Nov 25, 2022
Open
@vlaborie vlaborie mentioned this pull request May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

@ocelotl ocelotl

Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add or use missing metrics environment variables
3 participants
@ocelotl @srikanthccv @lzchen