Refactor metric format #2658
Merged
Refactor metric format #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
reviewed
May 4, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/export/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
force-pushed
the
issue_2646
branch
2 times, most recently
from
7c5b6da to
fe55d5c
Compare
srikanthccv
reviewed
May 6, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader.py
Outdated
Show resolved
Hide resolved
ocelotl
force-pushed
the
issue_2646
branch
2 times, most recently
from
bfebe11 to
0520bf4
Compare
This was referenced May 10, 2022
ocelotl
force-pushed
the
issue_2646
branch
14 times, most recently
from
95edbcd to
422e1c5
Compare
5 tasks
srikanthccv
reviewed
May 11, 2022
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-otlp-proto-grpc/tests/metrics/test_otlp_metrics_exporter.py
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Show resolved
Hide resolved
srikanthccv
reviewed
May 11, 2022
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/_view_instrument_match.py
Outdated
Show resolved
Hide resolved
srikanthccv
approved these changes
May 11, 2022
aabmass
reviewed
May 12, 2022
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
...rter-otlp-proto-grpc/src/opentelemetry/exporter/otlp/proto/grpc/_metric_exporter/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/aggregation.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/aggregation.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader_storage.py
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_metrics/_internal/metric_reader_storage.py
Show resolved
Hide resolved
…xporter/prometheus/__init__.py Co-authored-by: Aaron Abbott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2646
This PR has been refactored completely to address this comment.
Since this is a big PR, here is some information to help review:
This PR basically unflattens this
Metricobject to make it match the OTLPMetricobject, and it is implemented here.This means, our
Metricobject now contains aSum,HistogramorGaugeobject and those objects now contain a series ofNumberDataPointorHistogramDataPointobjects as defined by the proto.This changes many things but it is pretty much just a rearranging of data. The only "significant" change is that it was necessary to remove
_convert_aggregation_temporality, this conversion has been split and moved into each aggregationcollectmethod. I find it better since we now don't have all theifs that did something different depending on the point type but instead that specific code is moved into each aggregation that matches the corresponding point type.