Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update OTLP/HTTP example & test port to 4318 #2016

Merged
merged 5 commits into from
Oct 6, 2021
Merged

update OTLP/HTTP example & test port to 4318 #2016

merged 5 commits into from
Oct 6, 2021

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Aug 3, 2021 •
edited
Loading

Description

Update the OTLP over HTTP default port in the examples to match the spec. This also updates the classifier to Development Status :: 5 - Production/Stable as the spec confirmed the port moving forward.

Fixes #2015

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Does This PR Require a Contrib Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@codeboten codeboten marked this pull request as ready for review August 3, 2021 16:45
@codeboten codeboten requested review from a team, owais and lzchen and removed request for a team August 3, 2021 16:45
srikanthccv
srikanthccv previously approved these changes Aug 3, 2021
View reviewed changes
@ocelotl ocelotl added the Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary label Aug 3, 2021
lzchen
lzchen previously approved these changes Aug 4, 2021
View reviewed changes
@srikanthccv
Copy link
Member

We should probably hold this off for sometime open-telemetry/opentelemetry-specification#1847.

@ocelotl
Copy link
Contributor

ocelotl commented Aug 5, 2021

We should probably hold this off for sometime open-telemetry/opentelemetry-specification#1847.

Good call, I'm marking this PR as draft to avoid merging it accidentally. 👍

@ocelotl ocelotl marked this pull request as draft August 5, 2021 04:25
@owais
Copy link
Contributor

owais commented Aug 19, 2021

This should be 4317 according to https://github.com/tigrannajaryan/opentelemetry-specification/blob/da7ee47d6ce7913ea8e50ca2277a7485dd8b6dd5/specification/protocol/exporter.md

@ocelotl ocelotl marked this pull request as ready for review August 26, 2021 07:53
ocelotl
ocelotl previously approved these changes Aug 26, 2021
View reviewed changes
@ocelotl ocelotl changed the title update OTLP/HTTP port to 4318 update OTLP/HTTP port to 4317 Aug 26, 2021
@ocelotl ocelotl dismissed stale reviews from lzchen, srikanthccv, and themself August 26, 2021 07:55

I have added changes to this PR because @codeboten is out of office, please review again.

@ocelotl
Copy link
Contributor

ocelotl commented Aug 27, 2021

Since @codeboten is out of office these days, I tried to help and update the port but I am actually making matters worse with the docker tests 😅

I'll wait for @codeboten to come back ✌️

@codeboten codeboten changed the title update OTLP/HTTP port to 4317 update OTLP/HTTP port to 4318 Sep 14, 2021
@codeboten codeboten marked this pull request as draft September 14, 2021 18:00
@codeboten
Copy link
Contributor Author

Moving this back to draft waiting on open-telemetry/opentelemetry-collector#3765

@codeboten codeboten changed the title update OTLP/HTTP port to 4318 update OTLP/HTTP port to 4317 Sep 14, 2021
@codeboten
Copy link
Contributor Author

See also open-telemetry/opentelemetry-specification@32fcc01

@codeboten codeboten changed the title update OTLP/HTTP port to 4317 update OTLP/HTTP example & test port to 4318 Oct 1, 2021
@codeboten codeboten marked this pull request as ready for review October 1, 2021 17:59
@codeboten codeboten requested a review from ocelotl October 1, 2021 18:14
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 1, 2021
@srikanthccv
Copy link
Member

We initially made the package beta for not having clarity on the port number but looks like we released 1.0 in 3b190f5. @codeboten Would you mind updating the status here?

@codeboten
Copy link
Contributor Author

We initially made the package beta for not having clarity on the port number but looks like we released 1.0 in 3b190f5. @codeboten Would you mind updating the status here?

@lonewolf3739 updated, please take a look.

@owais owais enabled auto-merge (squash) October 6, 2021 15:50
@owais owais merged commit 65528f7 into open-telemetry:main Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl ocelotl approved these changes

@owais owais owais approved these changes

Assignees
No one assigned
Labels
Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update OTLP HTTP port
5 participants
@codeboten @srikanthccv @ocelotl @owais @lzchen