Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin version of pip installed #1457

Closed
wants to merge 3 commits into from

Conversation

codeboten
Copy link
Contributor

@codeboten codeboten commented Dec 8, 2020

Description

To unblock the build, pinning the version of pip to 20.2.4. It appears there's an issue causing trouble in the 20.3.x release.

Type of change

Please delete options that are not relevant.

  • Infrastructure change

Does This PR Require a Contrib Repo Change?

Answer the following question based on these examples of changes that would require a Contrib Repo Change:

  • The OTel specification has changed which prompted this PR to update the method interfaces of opentelemetry-api/ or opentelemetry-sdk/

  • The method interfaces of opentelemetry-instrumentation/ have changed

  • The method interfaces of test/util have changed

  • Scripts in scripts/ that were copied over to the Contrib repo have changed

  • Configuration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in

    • pyproject.toml
    • isort.cfg
    • .flake8
  • When a new .github/CODEOWNER is added

  • Major changes to project information, such as in:

    • README.md
    • CONTRIBUTING.md
  • Yes. - Link to PR:

  • No.

Checklist:

  • Followed the style guidelines of this project

@codeboten codeboten requested review from a team, toumorokoshi and hectorhdzg and removed request for a team December 8, 2020 05:26
@codeboten codeboten changed the title [WIP] pin version of pip installed pin version of pip installed Dec 8, 2020
@lzchen
Copy link
Contributor

lzchen commented Dec 8, 2020

Should we close this in favour of: #1456 ?

@codeboten
Copy link
Contributor Author

Sure that's fine. I guess the problem around installing the api/sdk and any package dependent on them with the [test] extra config will not work for us. Not sure if we need to create an issue to track this or not. Thoughts @lzchen?

@lzchen
Copy link
Contributor

lzchen commented Dec 8, 2020

@codeboten
I'm not sure what you mean? What is the issue?

@codeboten
Copy link
Contributor Author

I guess the remaining issue is really an issue w/ pip and not one for this repo. Downside of #1456 is that we end up with more steps when adding a package (which was what eachdist was trying to address in the first place...) Maybe this is a bigger discussion that can be had in the SIG meeting this week, what the right way to move forward with our approach to handling many packages.

@codeboten codeboten closed this Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants