Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MetricReader temporality controls #2627

Closed
aabmass opened this issue Apr 20, 2022 · 3 comments · Fixed by #2637
Closed

Implement MetricReader temporality controls #2627

aabmass opened this issue Apr 20, 2022 · 3 comments · Fixed by #2637
Assignees
@ocelotl
Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.

Comments

@aabmass
Copy link
Member

aabmass commented Apr 20, 2022

Temporality controls were changed in open-telemetry/opentelemetry-specification#2404 to allow specifying temporality defaults per instrument, with new defaults.
@aabmass aabmass added sdk Affects the SDK package. metrics 1.10.0rc1 release candidate 1 for metrics GA labels Apr 20, 2022
@ocelotl
Copy link
Contributor

ocelotl commented Apr 20, 2022

@aabmass this looks related to this (second part).

What do you think?

@ocelotl ocelotl self-assigned this Apr 20, 2022
@aabmass
Copy link
Member Author

aabmass commented Apr 21, 2022

Ah yes, that would cover it I think

@aabmass aabmass closed this as completed Apr 21, 2022
@lzchen
Copy link
Contributor

lzchen commented Apr 21, 2022

Reopening due to discussion in 4/21 SIG.

@lzchen lzchen reopened this Apr 21, 2022
@aabmass aabmass mentioned this issue Apr 21, 2022
Closed
@ocelotl ocelotl mentioned this issue Apr 21, 2022
Closed
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 22, 2022
@ocelotl
Implement MetricReader temporality controls
684ccbd 
Fixes open-telemetry#2627
@ocelotl ocelotl mentioned this issue Apr 22, 2022
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 22, 2022
@ocelotl
Implement MetricReader temporality controls
a24901b 
Fixes open-telemetry#2627
Fixes open-telemetry#2636
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 23, 2022
@ocelotl
Implement MetricReader temporality controls
0d06123 
Fixes open-telemetry#2627
Fixes open-telemetry#2636
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Apr 26, 2022
@ocelotl
Implement MetricReader temporality controls
60e4d16 
Fixes open-telemetry#2627
Fixes open-telemetry#2636
ocelotl added a commit that referenced this issue Apr 27, 2022
@ocelotl @srikanthccv
Implement MetricReader temporality controls (#2637)
b0777a3 
* Implement MetricReader temporality controls

Fixes #2627
Fixes #2636

* Fix type

* Add temporality check

* Fix check

* Fix check

* Fix lint

* Fix check

* Fix docs

* Add changelog

* Update changelog message

Co-authored-by: Srikanth Chekuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
1.10.0rc1 release candidate 1 for metrics GA metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement MetricReader temporality controls ocelotl/opentelemetry-python
3 participants
@aabmass @ocelotl @lzchen