Support newer httpx versions #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nozik
force-pushed
the
support_newer_httpx_versions
branch
from
a7b4175
to
30831a8
Compare
ocelotl
suggested changes
Jan 18, 2022
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Outdated
Show resolved
Hide resolved
|
@lzchen I don't have the time to dedicate to any maintenance. It looks like this is being handled okay, and I wouldn't be providing anything extra. |
nozik
force-pushed
the
support_newer_httpx_versions
branch
from
30831a8
to
e041297
Compare
owais
reviewed
Jan 26, 2022
...tion/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py
Show resolved
Hide resolved
ocelotl
approved these changes
Jan 27, 2022
owais
approved these changes
Jan 28, 2022
auto-merge was automatically disabled
January 28, 2022 12:18
Head branch was pushed to by a user without write access
nozik
force-pushed
the
support_newer_httpx_versions
branch
from
0703336
to
a03173f
Compare
auto-merge was automatically disabled
February 2, 2022 07:49
Head branch was pushed to by a user without write access
nozik
force-pushed
the
support_newer_httpx_versions
branch
3 times, most recently
from
fb685b0
to
37642d6
Compare
nozik
force-pushed
the
support_newer_httpx_versions
branch
from
37642d6
to
fb0e0fb
Compare
|
@nozik to fix the docs issue please try adding an exception |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support the latest versions of
httpx, currently only versions lower than0.19.0are supported.Type of change
How Has This Been Tested?
Adapting the existing tests of the previous versions of
httpx.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.