Better file naming for AWS XRay Propagator + Add NathanielRN Propagator CODEOWNER #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanielRN
added
the
Skip Changelog
lzchen
approved these changes
Oct 12, 2021
NathanielRN
force-pushed
the
move-aws-propagator-into-its-own-file
branch
2 times, most recently
from
10d79f5
to
7b8a526
Compare
owais
approved these changes
Oct 12, 2021
NathanielRN
force-pushed
the
move-aws-propagator-into-its-own-file
branch
2 times, most recently
from
9bd08d4
to
fcc9351
Compare
NathanielRN
removed
the
Skip Changelog
…athanielRN as Propagator owner
NathanielRN
force-pushed
the
move-aws-propagator-into-its-own-file
branch
from
fcc9351
to
ae20787
Compare
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #720
We put the propagator code in
aws_xray_format.pyinstead of__init__.pyto make it easier to find in the repo. By putting it as an export in the__init__.pyfile you can still import it at the same location.Also add myself @NathanielRN as a codeowner for the propagator so I get notified when there is a request to change it.
Description
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test make sure the import still works.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [ ] Changelogs have been updated- [ ] Unit tests have been added- [ ] Documentation has been updated