-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tortoise ORM instrumentation #685
Conversation
Requested CLA from Microsoft signatory. |
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Outdated
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Please add a note to the changelog about the new integration and unit tests.
instrumentation/opentelemetry-instrumentation-tortoiseorm/setup.cfg
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-tortoiseorm/setup.py
Outdated
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-tortoiseorm/setup.py
Outdated
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Show resolved
Hide resolved
Following the expectations from contributors, would it be alright if you were made a CODEOWNER for this package? |
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Outdated
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Outdated
Show resolved
Hide resolved
...emetry-instrumentation-tortoiseorm/src/opentelemetry/instrumentation/tortoiseorm/__init__.py
Outdated
Show resolved
Hide resolved
@tonybaloney |
Hi guys! this change is not merged, right? |
I think we forgot to merge this. It has enough approvals. If the tests pass, I will merge this; otherwise, they must be fixed first. |
eb0d997
to
61c2283
Compare
Co-authored-by: Diego Hurtado <[email protected]>
I added some commits while updating this branch.
@open-telemetry/python-approvers PTAL, big disclaimer: this instrumentation has no functional test cases. I added one just to make |
This has enough and can be merged 👍 . |
Description
This PR introduces an instrumentation module for Tortoise ORM https://tortoise-orm.readthedocs.io/en/latest/getting_started.html
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.