Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore: Make common span attributes compliant with semconv in spec #674

Merged
merged 8 commits into from
Oct 6, 2021

Conversation

mariojonke
Copy link
Contributor

@mariojonke mariojonke commented Sep 10, 2021

Description

This PR changes common span attributes for an AWS SDK call to make them comply with the semantic conventions in the spec:

  • adds rpc.system
  • changes aws.operation -> rpc.method
  • changes aws.service -> rpc.service

Attributes for which no semantic conventions exist are kept unchanged. These are:

  • aws.region
  • aws.request_id
  • retry_attempts

Simplifies unit tests as most of the assertions follow a similar pattern.

Type of change

  • Breaking change (changes semantic conventions of existing attributes)

How Has This Been Tested?

Existing tests have been adapted

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added

* use general rpc semconv for AWS SDK invocations as defined in the spec
* keep non spec compliant attributes (aws.region, aws.request_id, retry_attempts)
@mariojonke mariojonke requested a review from a team September 10, 2021 12:21
@lzchen lzchen merged commit 1960371 into open-telemetry:main Oct 6, 2021
@mariojonke mariojonke deleted the botocore-general-semconv branch October 8, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants