botocore: Make common span attributes compliant with semconv in spec #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use general rpc semconv for AWS SDK invocations as defined in the spec * keep non spec compliant attributes (aws.region, aws.request_id, retry_attempts)
owais
reviewed
Sep 10, 2021
...etry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/types.py
Outdated
Show resolved
Hide resolved
owais
reviewed
Sep 20, 2021
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Show resolved
Hide resolved
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Show resolved
Hide resolved
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Show resolved
Hide resolved
...pentelemetry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/__init__.py
Outdated
Show resolved
Hide resolved
...etry-instrumentation-botocore/src/opentelemetry/instrumentation/botocore/extensions/types.py
Show resolved
Hide resolved
owais
approved these changes
Sep 30, 2021
lzchen
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes common span attributes for an AWS SDK call to make them comply with the semantic conventions in the spec:
rpc.systemaws.operation->rpc.methodaws.service->rpc.serviceAttributes for which no semantic conventions exist are kept unchanged. These are:
aws.regionaws.request_idretry_attemptsSimplifies unit tests as most of the assertions follow a similar pattern.
Type of change
How Has This Been Tested?
Existing tests have been adapted
Does This PR Require a Core Repo Change?
Checklist: