Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about Falcon version support #611

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Add note about Falcon version support #611

merged 5 commits into from
Aug 13, 2021

Conversation

adriangb
Copy link
Contributor

@adriangb adriangb commented Aug 3, 2021

@owais I'm opening this partially so that I can get workflows to run on push and make my life easier in #607 . But also until #607 gets merged, this can't hurt to have 😄

@adriangb adriangb requested review from a team, codeboten and ocelotl and removed request for a team August 3, 2021 19:49
owais
owais approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@owais owais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha good hack :)

@owais owais added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 3, 2021
@adriangb
Copy link
Contributor Author

adriangb commented Aug 3, 2021

😢
Screen Shot 2021-08-03 at 4 47 36 PM

@adriangb
Copy link
Contributor Author

adriangb commented Aug 3, 2021

I added another commit to kick things off again. Hopefully tox doesn't hang for 40 min again

@owais
Copy link
Contributor

owais commented Aug 3, 2021

Ran the workflow again. Sorry about the terrible first experience. I'm thinking going back to Linux contribution of accepting patches via email might be better :)

I'll bring this up in our next SIG call and see if we can do anything to make it easier to contribute.

@adriangb
Copy link
Contributor Author

adriangb commented Aug 3, 2021

No worries! It's nice that this is at least on GH/GHA. Just working instructions in CONTRIBUTING.md would go a long way.

@adriangb
Copy link
Contributor Author

adriangb commented Aug 4, 2021

@owais looks like we're stuck again. tox has been running for hours (days?) with no output and without exiting 0 or 1

@ocelotl
Copy link
Contributor

ocelotl commented Aug 4, 2021

I am rerunning all the jobs, seems like several PRs are being stuck in CI and not only on this repo.

@adriangb
Copy link
Contributor Author

adriangb commented Aug 9, 2021

@ocelotl can you kick these off again? Last time the tests just timed out. I also merged master into this branch fwiw.

@ocelotl
Copy link
Contributor

ocelotl commented Aug 9, 2021

@ocelotl can you kick these off again? Last time the tests just timed out. I also merged master into this branch fwiw.

Sure, I have started them again. It is very likely that they will get stuck again 😞

I have filed an issue with Github here.

@adriangb
Copy link
Contributor Author

@lzchen something went wrong with your merge in e0243aa: 40ab25a is passing all tests, and also this PR is just a doc so it should never fail tests.

@lzchen lzchen merged commit e90452f into open-telemetry:main Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais approved these changes

@codeboten codeboten Awaiting requested review from codeboten

@ocelotl ocelotl Awaiting requested review from ocelotl

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adriangb @owais @ocelotl @lzchen