Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS entry points to match spec #566

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

NathanielRN
Copy link
Contributor

Description

Quick PR to change the name of the entry points for the opentelemetry-sdk-extension-aws package. They have been updated to be xray instead of aws_xray so we make this change just for consistency with other languages.

Fixes #565

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Should not need more tests since it doesn't change any code, only changes how the package is used.

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
    - [ ] Unit tests have been added
  • Documentation has been updated

@NathanielRN NathanielRN requested review from a team, owais and aabmass and removed request for a team July 5, 2021 17:46
@NathanielRN
Copy link
Contributor Author

@anuraaga Based of the guidance from the specs which outlined the value for OTEL_PROPAGATORS, I also changed the entry point for OTEL_PYTHON_ID_GENERATOR to be xray instead of aws_xray.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codeboten codeboten merged commit bddd082 into open-telemetry:main Jul 6, 2021
@NathanielRN NathanielRN deleted the update-aws-entry-points branch July 21, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS X-Ray propagator should be registered with xray environment variable
4 participants