Respect suppress instrumentation key in gRPC client #559
Conversation
RyanSiu1995
requested review from
a team,
codeboten and
srikanthccv
and removed request for
a team
RyanSiu1995
force-pushed
the
respect-suppress_instrumentation
branch
from
05889c6
to
b0e315f
Compare
| @@ -122,6 +123,9 @@ def _start_guarded_span(self, *args, **kwargs): | |||
| return _GuardedSpan(self._start_span(*args, **kwargs)) | |||
|
|
|||
| def intercept_unary(self, request, metadata, client_info, invoker): | |||
| if context.get_value(_SUPPRESS_INSTRUMENTATION_KEY): | |||
There was a problem hiding this comment.
Does this functionality need to be added to the server interceptor too?
There was a problem hiding this comment.
From all the implementations under contrib repo,
_SUPPRESS_INSTRUMENTATION_KEY is mainly used under the client side instead of server side.
So, I did not implement the server side at first place.
My preference is first to make sure the client side works as expected.
Then, we can investigate the server side implementation later on.
I want to make each PR only containing a single feature.
There was a problem hiding this comment.
It should definitely be done for the server side as well if you get a chance 😃
@RyanSiu1995 do you mind commenting on #476 so I can assign it to you?
There was a problem hiding this comment.
@RyanSiu1995
Would you like to contribute that in a separate PR as well?
| @@ -122,6 +123,9 @@ def _start_guarded_span(self, *args, **kwargs): | |||
| return _GuardedSpan(self._start_span(*args, **kwargs)) | |||
|
|
|||
| def intercept_unary(self, request, metadata, client_info, invoker): | |||
| if context.get_value(_SUPPRESS_INSTRUMENTATION_KEY): | |||
There was a problem hiding this comment.
It should definitely be done for the server side as well if you get a chance 😃
@RyanSiu1995 do you mind commenting on #476 so I can assign it to you?
Yes, sure! I will open up the change in server instrumentor really soon. |
|
@RyanSiu1995 please resolve the conflicts and we can get this merged, thanks! |
|
@codeboten Done and done! |
Description
Make gRPC client instrumentor respect
_SUPPRESS_INSTRUMENTATION_KEYFixes # (issue)
#476
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.