Update datadog exporter error tagging #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror tags on datadog span
ericmustin
requested review from
a team,
aabmass and
hectorhdzg
and removed request for
a team
…icmustin/opentelemetry-python-contrib into update_datadog_exporter_error_tagging merge upstream
ericmustin
changed the title
|
cc @majorgreys @alertedsnake @codeboten reviews welcome! cheers |
majorgreys
reviewed
Apr 22, 2021
|
@majorgreys I think so? our existing test raises an error with |
|
@ericmustin Thanks! Should a test be added for the fallback? Is there any scenario where this fallback is necessary? |
|
@majorgreys yea im not sure, i think let's just remove the old fallback approach, in practice we should never need it now, will update |
alertedsnake
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
This looks great, thanks @ericmustin! I'm glad you got a chance to work on it before I could :)
|
@majorgreys |
majorgreys
approved these changes
Apr 27, 2021
lzchen
approved these changes
Apr 27, 2021
codeboten
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #244(#244). I think this is ready for review, pretty straightforward, when span status is not
okwe iterate over events and look for exception info.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated Unit Tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.