Request/Response hooks for Tornado server and client #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
requested review from
a team,
codeboten and
lzchen
and removed request for
a team
11 tasks
lzchen
reviewed
Apr 9, 2021
lzchen
reviewed
Apr 9, 2021
| @@ -24,7 +24,7 @@ | |||
| from opentelemetry.instrumentation.tornado import TornadoInstrumentor | |||
|
|
|||
| # apply tornado instrumentation | |||
| TornadoInstrumentor().instrument() | |||
| # TornadoInstrumentor().instrument() | |||
There was a problem hiding this comment.
Do we need this to be commented?
lzchen
reviewed
Apr 9, 2021
.../opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
Show resolved
Hide resolved
lzchen
reviewed
Apr 9, 2021
.../opentelemetry-instrumentation-tornado/src/opentelemetry/instrumentation/tornado/__init__.py
Show resolved
Hide resolved
lzchen
reviewed
Apr 9, 2021
| @@ -65,15 +65,21 @@ def fetch_async(tracer, func, _, args, kwargs): | |||
| span.set_attribute(key, value) | |||
|
|
|||
| with trace.use_span(span): | |||
| if request_hook: | |||
There was a problem hiding this comment.
Any difference between calling request_hook within the use_span vs outside?
There was a problem hiding this comment.
Should be called right after the span is created right?
There was a problem hiding this comment.
No difference really. I'll move it out to avoid any future confusion.
lzchen
approved these changes
Apr 9, 2021
codeboten
suggested changes
Apr 12, 2021
| @@ -0,0 +1,7 @@ | |||
| OpenTelemetry Tornado Instrumentation | |||
There was a problem hiding this comment.
Is this the right place for this doc? i'm confused about the tornado/starlette/tornado.rst path.
There was a problem hiding this comment.
Sorry about that. No idea how that happened. My guess is an unintentional drag in vscode sidebar :)
lzchen
approved these changes
Apr 13, 2021
codeboten
approved these changes
Apr 13, 2021
|
@owais please address the conflicts so we can get this merged |
|
@codeboten updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for request and response hooks to Falcon instrumentation. Given how tornado works, we only have a single hook that gets called once per request. It gets passed the active handler instead of request/response objects.
Fixes #132
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.