Fix bug in how tokens are counted when streaming generateContent method is called.#4152
Merged
aabmass merged 3 commits intoopen-telemetry:mainfrom Feb 2, 2026
Merged
Conversation
github-actions
bot
assigned
codefromthecrypt,
karthikscale3,
lmolkova,
lzchen and
nirga
aabmass
approved these changes
Feb 2, 2026
Member
aabmass
left a comment
aabmass
left a comment
There was a problem hiding this comment.
Would be nice to have a cassette test for this since it's a slightly confusing implementation detail of their RPC responses.
wikaaaaa
pushed a commit
to wikaaaaa/opentelemetry-python-contrib
that referenced
this pull request
Feb 5, 2026
…thod is called. (open-telemetry#4152) * Fix token count bug * Add changelog * Fix changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't accumulate token counts across streaming responses from
generateContent, the cumulative count is returned each time, so just use what's returned in the response instead. See #4120Fixes #4120
Type of change
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.