Start MCP Instrumentation Library #3678
Conversation
|
|
||
| [project.optional-dependencies] | ||
| instruments = [ | ||
| "mcp >= 0.1.6", |
There was a problem hiding this comment.
Let's not make this mistake again, please. Can you bump this version to a relatively new one?
There was a problem hiding this comment.
No need to apologize, I meant because of Starlette and httpx.
| "instrumentation-genai/opentelemetry-instrumentation-mcp/tests/**/*.py", | ||
| "instrumentation-genai/opentelemetry-instrumentation-mcp/examples/**/*.py", |
There was a problem hiding this comment.
I'm disappointed this exclude section grew so much and by new projects... It was not supposed to be used by new projects.
I don't think it makes sense to add those 2. Supporting proper type hints from the beginning is easier.
|
@liustve 👋 the MCP semantic conventions from open-telemetry/semantic-conventions#2083 were just recently merged and released. Are you still interested in working on this? |
Hi @aabmass yes I'm still interested! Though my bandwidth is a bit limited right now I can allocate sometime every week to port in all of the instrumentation code in separate PRs |
Cool I am also interested in working on this, but we will have to figure out what to name this package since it is already taken by OpenLLMetry. We can possibly do a shared ownership with them like we do for some other packages, I'll have to check with @nirga |
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This PR has been closed due to inactivity. Please reopen if you would like to continue working on it. |
7 participants
Description
This PR begins the basic structure of adding instrumentation to the mcp following the same structure as:
AWS Distro for OpenTelemetry (ADOT) is in process of developing an mcp instrumentation library package and would like to contribute the work. It is currently limited to traces only and doesn't include metrics and log events.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.