Add consistent sampler#3668
Conversation
|
Thanks for working on this and providing those links! The Python repos are purposed a bit differently than Java. I think this new sampler might be better in opentelemetry-python SDK trace instead, with all other existing samplers. |
|
Thanks @tammy-baylis-swi - currently the sampler is a draft in the OTel spec so the idea is to be able to have a way to get something to try to verify and stabilize the spec. Would it still be appropriate in the main repo as a draft spec? |
I think so, though maybe the @open-telemetry/python-maintainers should chime in on this. We do use |
|
Thanks - I've opened a PR in the SDK repo so will close this one |
Description
Adds an implementation of consistent samplers
https://opentelemetry.io/docs/specs/otel/trace/tracestate-probability-sampling/
Based on the Java implementation
https://github.com/open-telemetry/opentelemetry-java-contrib/tree/main/consistent-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent56
Some differences from Java
TraceState)/cc @xrmx for maintainer review
/cc @PeterF778 as original author in Java if interested
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.