Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metrics from main branch #312

Merged
merged 21 commits into from
Feb 6, 2021
Merged

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Feb 4, 2021

Core pr: open-telemetry/opentelemetry-python#1568

As part of the discussion here

@lzchen lzchen requested review from a team, ocelotl and hectorhdzg and removed request for a team February 4, 2021 04:46
@lzchen lzchen changed the title [WIP] Remove metrics from main branch Remove metrics from main branch Feb 5, 2021
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question, otherwise it looks good.

# pylint:disable=W0212
request._otel_labels["http.status_code"] = str(
response.status_code
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like this was removed accidentally, i dont see this being metric related

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not removed accidently. request.otel_labels was added as a way to pass the labels needed to create duration metrics.

@lzchen lzchen merged commit c265e2f into open-telemetry:main Feb 6, 2021
@lzchen lzchen deleted the remove-metrics branch February 6, 2021 00:41
@mihirg
Copy link
Contributor

mihirg commented Feb 23, 2021

is there an alternative available for this package?

@lzchen
Copy link
Contributor Author

lzchen commented Feb 23, 2021

@mihirg
If you mean where the metrics functionality is found, you can find it under the metrics branch in this repo. It will be released as experimental once our 1.0.0 packages goes GA.

lzchen added a commit that referenced this pull request Feb 23, 2021
flands pushed a commit to open-telemetry/opentelemetry.io that referenced this pull request Jun 26, 2021
@luckydonald
Copy link

The docs seem broken in the process?

@lzchen
Copy link
Contributor Author

lzchen commented Dec 9, 2021

@luckydonald
Which docs are you referring to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants