Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure resources are not mutated #310

Merged
merged 7 commits into from
Feb 8, 2021

Conversation

codeboten
Copy link
Contributor

Description

As per the spec, a Resource is immutable, the boto instrumentation was changing this resource. This PR fixes this. This wass discovered as part of the work to

Fixes #309

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated
  • Documentation has been updated

@codeboten codeboten requested review from a team, aabmass and lzchen and removed request for a team February 2, 2021 04:58
@codeboten codeboten merged commit 7bd1d90 into open-telemetry:main Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource must be immutable
3 participants