Case insensitive header key retrieval for asgi instrumentation #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garnertan
requested review from
a team,
codeboten and
toumorokoshi
and removed request for
a team
toumorokoshi
approved these changes
Feb 1, 2021
codeboten
approved these changes
Feb 1, 2021
There was a problem hiding this comment.
LGTM, just needs a quick update to the changelog as per @toumorokoshi's comment. Also please sign the CLA
garnertan
force-pushed
the
main
branch
2 times, most recently
from
be768c0
to
4d1ed02
Compare
|
Thanks for reviewing. I added the pull request in the changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made Asgi Instrumentor retrieve header keys in lower case.
Fixes #307
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e test-instrumentation-asgi
Added new test cases in test_getter.py
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.