Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry-instrumentation: make it easier to use bootstrap with custom values #2918

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Oct 21, 2024

Description

Pass the available instrumentation libraries and the default libraries from bootstrap_gen to run() (and down to all the functions) instead of relying on the globals. This way it's easier to reuse run() with custom values.

While at it fix mock handling in tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx requested a review from a team as a code owner October 21, 2024 07:24
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 21, 2024
…ustom values

Pass the available instrumentation libraries and the default libraries
from bootstrap_gen to run() (and down to all the functions) instead of
relying on the globals. This way it's easier to reuse run with custom
values.

While at it fix mock handling in tests.
@xrmx xrmx requested a review from pmcollins October 24, 2024 08:15
Copy link
Member

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice to have these improvements.

@lzchen lzchen merged commit 5c566a0 into open-telemetry:main Oct 24, 2024
536 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants