Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC instrumentation: client additions #269

Merged
merged 13 commits into from
Feb 5, 2021

Commits on Feb 4, 2021

  1. Add rpc fields in the spec to client interceptor

    Michael Stella authored and alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    5076087 View commit details
    Browse the repository at this point in the history
  2. Rework how the client instruments

    Michael Stella authored and alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    28bacd1 View commit details
    Browse the repository at this point in the history
  3. grpc client fix, additional tests

    Add tests for the new attributes
    Michael Stella authored and alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    83f27d2 View commit details
    Browse the repository at this point in the history
  4. gRPC client instrumentation docs fixes

    Bugfix for docs that led me astray for a good half hour :)
    Michael Stella authored and alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    546d623 View commit details
    Browse the repository at this point in the history
  5. run black

    Michael Stella authored and alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    82ee18f View commit details
    Browse the repository at this point in the history
  6. Why do I always have to run black twice?

    Michael Stella authored and alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    b911c52 View commit details
    Browse the repository at this point in the history
  7. Fix client metric labels

    The docs on metric labels suggests that they should probably be strings,
    and all others I can find are strings, and so these ought to be also.
    Otherwise, some of the exporters/processors have to handle things
    specifically, and not all of these come out as nice as could be when you
    `str()` them.
    
    I've also made sure to use the `StatusCode` name, as that's the
    interesting thing.
    
    Finally, there's no need to report specifically that `error=false`, so
    I've removed that tag.
    alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    6aa158e View commit details
    Browse the repository at this point in the history
  8. Update/fix tests, fix code

    Hey, good thing there are tests.
    
    Also, I did the `sorted()` thing in here so future us don't have to
    think about the ordering of these when writing new tests :)
    alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    6a0dd0f View commit details
    Browse the repository at this point in the history
  9. black

    alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    9c3aada View commit details
    Browse the repository at this point in the history
  10. Appease the linter

    This code passed before, so something clearly changed.
    alertedsnake committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    abda221 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Configuration menu
    Copy the full SHA
    e47adea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3abab94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fd5b460 View commit details
    Browse the repository at this point in the history