-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC instrumentation: client additions #269
Merged
codeboten
merged 13 commits into
open-telemetry:main
from
alertedsnake:grpc-client-additions
Feb 5, 2021
Merged
gRPC instrumentation: client additions #269
codeboten
merged 13 commits into
open-telemetry:main
from
alertedsnake:grpc-client-additions
Feb 5, 2021
Commits on Feb 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5076087 - Browse repository at this point
Copy the full SHA 5076087View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28bacd1 - Browse repository at this point
Copy the full SHA 28bacd1View commit details -
grpc client fix, additional tests
Add tests for the new attributes
Configuration menu - View commit details
-
Copy full SHA for 83f27d2 - Browse repository at this point
Copy the full SHA 83f27d2View commit details -
gRPC client instrumentation docs fixes
Bugfix for docs that led me astray for a good half hour :)
Configuration menu - View commit details
-
Copy full SHA for 546d623 - Browse repository at this point
Copy the full SHA 546d623View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82ee18f - Browse repository at this point
Copy the full SHA 82ee18fView commit details -
Configuration menu - View commit details
-
Copy full SHA for b911c52 - Browse repository at this point
Copy the full SHA b911c52View commit details -
The docs on metric labels suggests that they should probably be strings, and all others I can find are strings, and so these ought to be also. Otherwise, some of the exporters/processors have to handle things specifically, and not all of these come out as nice as could be when you `str()` them. I've also made sure to use the `StatusCode` name, as that's the interesting thing. Finally, there's no need to report specifically that `error=false`, so I've removed that tag.
Configuration menu - View commit details
-
Copy full SHA for 6aa158e - Browse repository at this point
Copy the full SHA 6aa158eView commit details -
Hey, good thing there are tests. Also, I did the `sorted()` thing in here so future us don't have to think about the ordering of these when writing new tests :)
Configuration menu - View commit details
-
Copy full SHA for 6a0dd0f - Browse repository at this point
Copy the full SHA 6a0dd0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c3aada - Browse repository at this point
Copy the full SHA 9c3aadaView commit details -
This code passed before, so something clearly changed.
Configuration menu - View commit details
-
Copy full SHA for abda221 - Browse repository at this point
Copy the full SHA abda221View commit details
Commits on Feb 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e47adea - Browse repository at this point
Copy the full SHA e47adeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3abab94 - Browse repository at this point
Copy the full SHA 3abab94View commit details -
Merge branch 'main' into grpc-client-additions
alrex authoredFeb 5, 2021 Configuration menu - View commit details
-
Copy full SHA for fd5b460 - Browse repository at this point
Copy the full SHA fd5b460View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.