Fix KafkaProducer.send() arguments in opentelemetry-instrumentation-kafka-python#2125
Closed
holmuk wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Fix KafkaProducer.send() arguments in opentelemetry-instrumentation-kafka-python#2125holmuk wants to merge 2 commits intoopen-telemetry:mainfrom
holmuk wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
michaelsafyan
added a commit
to michaelsafyan/open-telemetry.opentelemetry-python-contrib
that referenced
this pull request
Apr 17, 2025
aabmass
pushed a commit
that referenced
this pull request
Apr 23, 2025
…or the Google GenAI SDK instrumentation (#3374) * Create a utility to simplify recording request attributes. * Update recording mechanism to record more request options. * Improve the recording of span request attributes. * Reformat with ruff. * Update TODOs to reflect change made here. * Update changelog now that PR has been created and can be referenced. * Fix lint issues. * Reformat with ruff. * Add more documentation comments requested in the pull request. * Add tests and comments that provide some additional clarity regarding the flattening logic in response to PR comments. * Add tests and comments that provide some additional clarity regarding the flattening logic in response to PR comments. * Handle corner case where flatten function returns compound output. * Update prefix to match currently proposed SemConv. * Update to specify attributes from SemConv constants per PR feedback. * Use an allowlist for dynamic keys per PR feedback. * Reformat with ruff. * Fix lint issues. * Reformat with ruff. * Handle flattening errors more gracefully. * Add support for more wildcards in the allowlist. * Add a clearer type for the flatten functions. * Simplify 'exclude_keys' initialization per PR feedback. * Simplify AllowList constructor type annotation per PR feedback. * Reformat with ruff. * Resolve lint error concerning too many returns. * Reformat with ruff. * Update name to reflect requested changes in Semantic Conventions pull request #2125. * Add test to verify correct handling of Unicode. * Reformat with ruff. * Remove deuplicated test.
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This PR has been closed due to inactivity. Please reopen if you would like to continue working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It appears there is a bug with instrumentation when we call
KafkaProducer.sendwith someheadersargument inargs:We get
TypeError: KafkaProducer.send() got multiple values for argument 'headers'when running the code with enabled instrumentation.This PR fixes the issue.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.