-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arity of context.abort for AIO RPCs #2066
Merged
lzchen
merged 9 commits into
open-telemetry:main
from
cookiefission:grpc-aio-abort-arity
Nov 28, 2023
Merged
Fix arity of context.abort for AIO RPCs #2066
lzchen
merged 9 commits into
open-telemetry:main
from
cookiefission:grpc-aio-abort-arity
Nov 28, 2023
Commits on Nov 16, 2023
-
Add test for aborting grpc.aio server RPC with trailing_metadata
This is basically a copy of the existing test_abort but passes trailing_metadata. This test fails because the `code()` and `details()` from the returned exception are masking the actual abort reason due to the bug.
Configuration menu - View commit details
-
Copy full SHA for f574142 - Browse repository at this point
Copy the full SHA f574142View commit details -
Switch grpc.aio interceptor to use correct context
This adds a separate ServicerContext for the grpc.aio interceptor to use that inherits from the correct grpc.aio.ServicerContext. Previously it was ultimately using grpc.ServicerContext where the abort method has a different signature to what should have been in use.
Configuration menu - View commit details
-
Copy full SHA for 8c3471c - Browse repository at this point
Copy the full SHA 8c3471cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b311422 - Browse repository at this point
Copy the full SHA b311422View commit details
Commits on Nov 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c97fb5e - Browse repository at this point
Copy the full SHA c97fb5eView commit details
Commits on Nov 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 561dd29 - Browse repository at this point
Copy the full SHA 561dd29View commit details
Commits on Nov 21, 2023
-
Use wrapt.ObjectProxy for _OpenTelemetryAioServicerContext
Using wrapt eliminates a bunch of the boilerplate associated with inheriting from grpc.aio.ServicerContext directly. It also means that if methods are added or their signatures change, there will only be a breaking change for abort, set_code, or set_details.
Configuration menu - View commit details
-
Copy full SHA for dda47a1 - Browse repository at this point
Copy the full SHA dda47a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cce9836 - Browse repository at this point
Copy the full SHA cce9836View commit details -
Configuration menu - View commit details
-
Copy full SHA for 62018db - Browse repository at this point
Copy the full SHA 62018dbView commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0c1b3f1 - Browse repository at this point
Copy the full SHA 0c1b3f1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.