Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arity of context.abort for AIO RPCs #2066

Merged
merged 9 commits into from
Nov 28, 2023

Commits on Nov 16, 2023

  1. Add test for aborting grpc.aio server RPC with trailing_metadata

    This is basically a copy of the existing test_abort but passes
    trailing_metadata. This test fails because the `code()` and `details()`
    from the returned exception are masking the actual abort reason due to
    the bug.
    cookiefission committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    f574142 View commit details
    Browse the repository at this point in the history
  2. Switch grpc.aio interceptor to use correct context

    This adds a separate ServicerContext for the grpc.aio interceptor to
    use that inherits from the correct grpc.aio.ServicerContext. Previously
    it was ultimately using grpc.ServicerContext where the abort method has
    a different signature to what should have been in use.
    cookiefission committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    8c3471c View commit details
    Browse the repository at this point in the history
  3. Update CHANGELOG

    cookiefission committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    b311422 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Configuration menu
    Copy the full SHA
    c97fb5e View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    561dd29 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Use wrapt.ObjectProxy for _OpenTelemetryAioServicerContext

    Using wrapt eliminates a bunch of the boilerplate associated with
    inheriting from grpc.aio.ServicerContext directly. It also means that if
    methods are added or their signatures change, there will only be a
    breaking change for abort, set_code, or set_details.
    cookiefission committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    dda47a1 View commit details
    Browse the repository at this point in the history
  2. Address linting issues

    cookiefission committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    cce9836 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    62018db View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    0c1b3f1 View commit details
    Browse the repository at this point in the history